Date: Fri, 31 Mar 2006 11:57:14 +0200
From: Jens Axboe <axboe@suse.de>
To: tridge@samba.org
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] splice support #2
Message-ID: <20060331095711.GK14022@suse.de>
References: <17452.50912.404106.256236@samba.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <17452.50912.404106.256236@samba.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 923
Lines: 27

On Fri, Mar 31 2006, tridge@samba.org wrote:
> Linus and Jens,
> 
> Stephen Rothwell just pointed me at the new splice() interface. Looks
> really nice!
> 
> One comment though. Could we add a off_t to splice to make it more
> like pwrite() ? Otherwise threads could get painful with race
> conditions between the seek and the splice() call.
> 
> Either that or add psplice() like this:
> 
>   ssize_t psplice(int fdin, int fdout, size_t len, off_t ofs, unsigned flags);
> 
> where ofs sets the offset to read from fdin. 

I definitely see some valid reasons for adding a file offset instead of
using ->f_pos, I'll leave that decision up to Linus though. Linus?

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/