Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 3/3] drm/amdgpu: Change type of module param
 `ppfeaturemask` to hexint
To:     Paul Menzel <pmenzel@molgen.mpg.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Alex Deucher <alexander.deucher@amd.com>
Cc:     amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20200703142939.28663-1-pmenzel@molgen.mpg.de>
 <20200703142939.28663-3-pmenzel@molgen.mpg.de>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <50e7239f-9fab-8484-7aec-085acc5ec658@amd.com>
Date:   Fri, 3 Jul 2020 17:29:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
In-Reply-To: <20200703142939.28663-3-pmenzel@molgen.mpg.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7] (2a02:908:1252:fb60:be8a:bd56:1f94:86e7) by AM0PR08CA0029.eurprd08.prod.outlook.com (2603:10a6:208:d2::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.21 via Frontend Transport; Fri, 3 Jul 2020 15:29:10 +0000
X-Originating-IP: [2a02:908:1252:fb60:be8a:bd56:1f94:86e7]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: a2fdc63b-774f-4475-17f0-08d81f65d615
X-MS-TrafficTypeDiagnostic: MN2PR12MB3839:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MN2PR12MB3839DDF6540974C5A811898E836A0@MN2PR12MB3839.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-Forefront-PRVS: 045315E1EE
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wUAm/PbnchD8TRuvdQ1Rp40ymHhW7Y2rD+HrJARenBrPD4ychM8avMHTHRIeED8f20D38GOffy+rUNfxM2DuTRuMVfRn/tbdvufWmAYvxEz1ALtHvc1UlTILOa1n7kqaGt5tvkOZIVbyl3GqwVU+duyWEfi9TWxuhBczgtemr8CdxpFoxQhzzMLztDKxzdpbVNiBToZixMHsM6iXn/hwi/HqpixAQ4JAX+jLHv7wYfFkQcbuXShgB15yMSWAUiw9PyUfocF/LrAtRwBANz1JbFtGN9d73341Co2RzQnIEFxYFUx/A0Ga/nAPUwUii00lZXja7dOd5vHHuBCzd+oYu2z2BS37cMf7Wqxid6nGTE9CBwnWDHJcxHMA1zArCb4Am8/igHSixMVVAeb6MM/4oA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(366004)(136003)(39860400002)(396003)(376002)(31686004)(16526019)(316002)(5660300002)(186003)(2616005)(8936002)(8676002)(66556008)(66476007)(110136005)(52116002)(66946007)(4326008)(86362001)(478600001)(31696002)(83380400001)(6486002)(6636002)(6666004)(2906002)(36756003)(81973001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: u7O+ZgBM9Oh1ZD2FAo4CcndV00am0qttbvzIt5uOaAlSynLXjlfA9EPlBjM0d0/yYFG8GgP5jkLP0tLWsnthkvoGCkbcQ1woI/5PayG9ZYA3DbzQCL+MZ1IzG7qrP3WwwMbXv7KmgN+fOIwDG92X2xyY3Kd2wrKDciRh09U8LNW5LyM95NUJjBziTTOYXIhqQRnlE0M5f5Bd1VRkkU0E0HI8PhjoFTNwzXyUGfR4vq8T+hAXaqRpgcpReIR+3IYx0eFW7OlFfiI2ErFwt7aXefI7IinaTUAp1QnMqH7JmdmOBfOcAxGULvXTJLIWfYhWzOnVrpIV7THYAg3wRh95pP2exwLRO/VPa/LrzYnvbBZ/2fow4Zq46L+jNFEZ2JCCsGTvEdGJh576yvxrDilEaqNwlp3D5sXKKimVU7mtb/puvEl2VRXaOBTI86wrWsYauAWcG7JCp/NUKSYYifMsKYtGMl/crx0p5w4Py/XqT+NL1/OJiTVBwY945V2nGwV8zQb4+8TBMZGPyS9p+nJ2xEc+gzXr3D5M6/1RkFsNnXRpOopnoDMwD3MRl/OR1Rtb
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2fdc63b-774f-4475-17f0-08d81f65d615
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2020 15:29:11.8948
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7ZiT2I58EHHSoOPzrgtqd9OMVBMJbokNwM8rrusKJAPY/Im2hWXaDRtzD2Wf3NIN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3839
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 03.07.20 um 16:29 schrieb Paul Menzel:
> The newly added hexint helper is more convenient for bitmasks.
>
> Before:
>
>      $ more /sys/module/amdgpu/parameters/ppfeaturemask
>      4294950911
>
> After:
>
>      $ more /sys/module/amdgpu/parameters/ppfeaturemask
>      0xffffbfff
>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

Reviewed-by: Christian König <christian.koenig@amd.com> for this one.

Feel free to add my Acked-by to the other two, but I'm not familiar 
enough with the code to review those.

Regards,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 126e74758a34..5c4263335cba 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -391,12 +391,12 @@ MODULE_PARM_DESC(sched_hw_submission, "the max number of HW submissions (default
>   module_param_named(sched_hw_submission, amdgpu_sched_hw_submission, int, 0444);
>   
>   /**
> - * DOC: ppfeaturemask (uint)
> + * DOC: ppfeaturemask (hexint)
>    * Override power features enabled. See enum PP_FEATURE_MASK in drivers/gpu/drm/amd/include/amd_shared.h.
>    * The default is the current set of stable power features.
>    */
>   MODULE_PARM_DESC(ppfeaturemask, "all power features enabled (default))");
> -module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, uint, 0444);
> +module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, hexint, 0444);
>   
>   /**
>    * DOC: forcelongtraining (uint)