Subject: Re: [PATCH] ioremap_cached()
From: Arjan van de Ven <arjan@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <20060330164120.GJ13590@parisc-linux.org>
References: <20060330164120.GJ13590@parisc-linux.org>
Content-Type: text/plain
Date: Fri, 31 Mar 2006 13:20:44 +0200
Message-Id: <1143804045.3053.7.camel@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1126
Lines: 23


> 
> It seems clear to me that ioremap() and ioremap_nocache() are the
> wrong way around.  The default needs to be uncached -- and the obvious
> (rare) alternative becomes ioremap_cached().
> 
> So here's a patch for i386 to add ioremap_cached() and make ioremap()
> uncached.  ioremap_nocache() remains as an alias for ioremap() so we
> don't needlessly break old drivers.  Architecture maintainers will need
> to fix up their ports if this patch is accepted.

I'd actually suggest deprecating ioremap() and moving away from it to
make sure all users think of which variant they want. Explicit naming is
always better than "some" unknown behavior (especially for old drivers
that work on multiple kernels... while you allow them to keep compiling,
you change the world under them so I think eventually break them
compiling is actually better than having them limp along broken)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/