Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2495426ybt; Fri, 3 Jul 2020 10:21:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUUfbvcyXYYA1uTZfscC9f6hxEW4QWH1nOcMUlWi2ei/AwbyfKKmFfhhbU6hAbFmgrEjcE X-Received: by 2002:aa7:da90:: with SMTP id q16mr34122237eds.44.1593796896410; Fri, 03 Jul 2020 10:21:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593796896; cv=none; d=google.com; s=arc-20160816; b=N2rRYDsXeOCFGFfyqqfn9DPzaulAF8kEGcehxSl65QUgIWEGRr37lLMQGI9kUd1kAI JTyZglVipO58RMfBZiI6EMm0WuwLI6tNReAtIRKgTeszEMApcyA32Ca72mgIEeYlLzkC /nBKXlQf1Opzxfifst3Rxi6dd3H8NxN7nE0535JS90J09aJwAheFY7PnzTSLmtepWG9Z CIZYnwqj5PwFHEnGYd7yoOXwuds+D2baE6XiqM897YOp/aWmJm1cDhEtOEiOA19fDvyT os4o28gUPoLdvPOZ/UcU+vxR6TbCYOVnY9Qj8J8nzskwZQCsDfpau+0hKyqUoFa8RkC9 f7qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=GIrvmUybK9vIMsIuhctNNg5TFcmK5sb/DzyUMikX9ag=; b=jP96wOEVx5Oez4gTV/bHe6bFgwwB5H0QHldi4uqq0YurOvAQ1TRWnY94gYp4jN4jPY nkTMo0GKIo/CVwHV72eNiC6m0oNVeKe7mp8w9uHaWJ6xJlLucnmB9swMum6zYCXtDDAl TnsHWE2D3KCTzLdlhOc1dvGYH7bcgW3cljUjJb7AwDkoHDB2ty7mivFmZn+1CCjntWgb +N6d4EJ3s3ZAh8y79PK/jWrJTxdiWXDd2ZymAR81sJRD4YizeFCvRsJehNxe7sjmROCc Dx/q23XE9kA9VHyZYamPYyg0VyHnXOQ6NTgajkE/3I0vSTVfMTjdziFW7/+MmJT9VVgq c5Eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OcfvNsQ1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e10si8194925ejj.546.2020.07.03.10.21.13; Fri, 03 Jul 2020 10:21:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OcfvNsQ1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726669AbgGCRU3 (ORCPT + 99 others); Fri, 3 Jul 2020 13:20:29 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:30500 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726148AbgGCRU3 (ORCPT ); Fri, 3 Jul 2020 13:20:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593796828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GIrvmUybK9vIMsIuhctNNg5TFcmK5sb/DzyUMikX9ag=; b=OcfvNsQ1JkTWx1my8Shq1xCvxhSyNb9O5NVloyY4Ky09fed4Q1Aqmf9Ju2R2Y76XBJYzNI ULF+Abrfc7VEvPA739x5S9xs/zSKihNV4iD2cXu9AsG98V0d0aZreZjcrAYLRmo3wXtRJt aiBdZ9cRsTuMKHzlfTVbFxxDtE2tbLI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-259-AN0LAMTJNc62Tw5O5BHtaQ-1; Fri, 03 Jul 2020 13:20:26 -0400 X-MC-Unique: AN0LAMTJNc62Tw5O5BHtaQ-1 Received: by mail-wr1-f72.google.com with SMTP id j3so12723098wrq.9 for ; Fri, 03 Jul 2020 10:20:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GIrvmUybK9vIMsIuhctNNg5TFcmK5sb/DzyUMikX9ag=; b=mgSSL6LRdMXAcxjeyxfngb1Zui9G3wGcygdwLvi3g63a0tZbbYbCRUGFrKOitno4Mg 00ygFCFfs3wjG6Xzm27IXK1a1KOmWo2lkaOFHUhA9ti2umz/j3/ZjuT3l0FzJmCpZi+o PYhG1gYBtNLDRJNV79gTAF4iQnQkCfmxF/OT2746YkfgUGZAij2wSpTq+oXywpaJG270 uqmiGY6uk1I/AOhd/UiV6U09q30Qfoa7YSLYr18a+UP/SwPtaf1PrZsXyWSwNHFDqGz5 PcPJwMDdaHeBAHH5Bzy+PJmLAaX1cfW8B0S3majfoJz4VESpO0aYxi34a5p8/14s9Sd1 AQjw== X-Gm-Message-State: AOAM531r0ow21Gb7PqB3TdDvd4P+Grciw4YX21OlitczwfGsQliDr8CB xHZ1PAIJuWVUQ+LRsZxR4QzvYAODIfaO5yegROD2ZiWkmNKIjp47YxCs8axWHChZ10HjsnoRnDS UPlOhhqas8q9VP6cRelEc1XBs X-Received: by 2002:a5d:62d1:: with SMTP id o17mr36751680wrv.162.1593796825661; Fri, 03 Jul 2020 10:20:25 -0700 (PDT) X-Received: by 2002:a5d:62d1:: with SMTP id o17mr36751657wrv.162.1593796825426; Fri, 03 Jul 2020 10:20:25 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:5cf9:fc14:deb7:51fc? ([2001:b07:6468:f312:5cf9:fc14:deb7:51fc]) by smtp.gmail.com with ESMTPSA id z10sm9510926wrm.21.2020.07.03.10.20.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2020 10:20:24 -0700 (PDT) Subject: Re: [PATCH 0/6] KVM: x86/mmu: Files and sp helper cleanups To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200622202034.15093-1-sean.j.christopherson@intel.com> From: Paolo Bonzini Message-ID: Date: Fri, 3 Jul 2020 19:20:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200622202034.15093-1-sean.j.christopherson@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/06/20 22:20, Sean Christopherson wrote: > Move more files to the mmu/ directory, and an mmu_internal.h to share > stuff amongst the mmu/ files, and clean up the helpers for retrieving a > shadow page from a sptep and/or hpa. > > Sean Christopherson (6): > KVM: x86/mmu: Move mmu_audit.c and mmutrace.h into the mmu/ > sub-directory > KVM: x86/mmu: Move kvm_mmu_available_pages() into mmu.c > KVM: x86/mmu: Add MMU-internal header > KVM: x86/mmu: Make kvm_mmu_page definition and accessor internal-only > KVM: x86/mmu: Add sptep_to_sp() helper to wrap shadow page lookup > KVM: x86/mmu: Rename page_header() to to_shadow_page() > > arch/x86/include/asm/kvm_host.h | 46 +--------------------- > arch/x86/kvm/mmu.h | 13 ------ > arch/x86/kvm/mmu/mmu.c | 58 +++++++++++++++------------ > arch/x86/kvm/{ => mmu}/mmu_audit.c | 12 +++--- > arch/x86/kvm/mmu/mmu_internal.h | 63 ++++++++++++++++++++++++++++++ > arch/x86/kvm/{ => mmu}/mmutrace.h | 2 +- > arch/x86/kvm/mmu/page_track.c | 2 +- > arch/x86/kvm/mmu/paging_tmpl.h | 4 +- > 8 files changed, 108 insertions(+), 92 deletions(-) > rename arch/x86/kvm/{ => mmu}/mmu_audit.c (96%) > create mode 100644 arch/x86/kvm/mmu/mmu_internal.h > rename arch/x86/kvm/{ => mmu}/mmutrace.h (99%) > Queued, thanks. Paolo