Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200703100810.12304-1-cw00.choi@samsung.com> <CGME20200703095657epcas1p187b7f90a4a33da7791a83a78760f3a91@epcas1p1.samsung.com>
 <20200703100810.12304-3-cw00.choi@samsung.com> <6027cf29-ea6f-0a27-3e39-a80c24b80bb8@gmail.com>
In-Reply-To: <6027cf29-ea6f-0a27-3e39-a80c24b80bb8@gmail.com>
From:   Chanwoo Choi <chanwoo@kernel.org>
Date:   Sat, 4 Jul 2020 05:34:11 +0900
Message-ID: <CAGTfZH1uWaSHW5+URTj3SjvxRRZqF9WtMfofe+8X7BHCrk3R0g@mail.gmail.com>
Subject: Re: [PATCH 2/2] PM / devfreq: Add governor flags to clarify the features
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Chanwoo Choi <cw00.choi@samsung.com>,
        Linux PM list <linux-pm@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Leonard Crestez <leonard.crestez@nxp.com>, lukasz.luba@arm.com,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Lin Huang <hl@rock-chips.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        jonathanh@nvidia.com, Abel Vesa <abel.vesa@nxp.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Dmitry,

On Fri, Jul 3, 2020 at 7:46 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> 03.07.2020 13:08, Chanwoo Choi =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra3=
0-devfreq.c
> > index e94a27804c20..620ecd250d7c 100644
> > --- a/drivers/devfreq/tegra30-devfreq.c
> > +++ b/drivers/devfreq/tegra30-devfreq.c
> > @@ -765,10 +765,12 @@ static int tegra_governor_event_handler(struct de=
vfreq *devfreq,
> >
> >  static struct devfreq_governor tegra_devfreq_governor =3D {
> >       .name =3D "tegra_actmon",
> > +     .flag =3D DEVFREQ_GOV_FLAG_ATTR_COMMON
> > +             | DEVFREQ_GOV_FLAG_ATTR_POLLING_INTERVAL,
>
> Hello, Chanwoo!
>
> There is a typo here, it should be ".attr =3D ".

Ah. Sorry. After changed the name, I didn't test COMPILE_TEST.

>
> > +     .flag =3D DEVFREQ_GOV_FLAG_FLAG_IMMUTABLE,
> > +             | DEVFREQ_GOV_FLAG_FLAG_IRQ_DRIVEN,
>
> There is a typo here too FLAG_FLAG ^

Thanks.

--=20
Best Regards,
Chanwoo Choi
Samsung Electronics