Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2712603ybt; Fri, 3 Jul 2020 17:08:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8qM++Inp1ph7mzZKutOR7TPyvtS2aul7LJbRexTkD0KYbFocIq5Ijbbis6qVKyXtJhZzX X-Received: by 2002:a05:6402:1494:: with SMTP id e20mr31363240edv.2.1593821293028; Fri, 03 Jul 2020 17:08:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593821293; cv=none; d=google.com; s=arc-20160816; b=V0BpWDDvhFqhtDyraBVEK7v493m4r1pqO2hqZ+MfsEn4MfF7NB12GPPKF+BDj+fzJa 0V9ZuBm9LZqEL3GrWpONp8urM+S5zDTUiId0Qp4lpRjag38zhPxSazzz0YeMAZDTVxi/ HEz3/d7iTd+G5ML8JMgmkDMt8sCdEF5z8kb7Gei/ICM8nlVRIQihrFp3kpifE2X3SN8f pHWQjFa5YT+9tEnlSX+pvWpct3TGSMSS8IsUi353pLjaaME4Isrm7M5tTvh/YugZtH3R M+76NY5Asq0IONLD58CzB/b/Ltny+OFCxuuXrOHJeZNlaLhx4Zcv0dzcTJW6TNFX78/0 QWLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=4YOIG7PuR/NvQtR6oRkgdR9C6F+K0G6SJUN1/8gkKh4=; b=azupn4zVGU/kfMbZJ8MPSV/8XfIvUf8O0hQ62kdK8TIgyLx/0fZ0L9InIWEYsLR/2f oUlL02tx9Y+gmLDasphcQZw0w6RwXH2OdozDn4/Wm+DGQKap0OXvhke7+7hFYCfxHLMx WpqlCc9y1sGJjZ5ZPjSUjitsW+FZj6rC9XSllQpgBDN5T4UXna5zGx2B3HdH33WLIP8a S5i6YTBEn0G3g1Zci87+Z6lOVyDnMLwam8ouYu5uZ3eODtHgjizSYQQNKfblfC9Ex3Ci +28QQYyRBUM9JaCTTfIZenIMoHWvuciMoz6XYlGXDbVQSsj3QWxIfwZVWe9sVLVp0Xb7 Cj8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v25si8477916ejx.496.2020.07.03.17.07.50; Fri, 03 Jul 2020 17:08:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726794AbgGDAHK (ORCPT + 99 others); Fri, 3 Jul 2020 20:07:10 -0400 Received: from correo.us.es ([193.147.175.20]:56236 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbgGDAHK (ORCPT ); Fri, 3 Jul 2020 20:07:10 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 16AB2ED5CA for ; Sat, 4 Jul 2020 02:07:09 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 03B2FDA78E for ; Sat, 4 Jul 2020 02:07:09 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id E2D73DA797; Sat, 4 Jul 2020 02:07:08 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id B3186DA73F; Sat, 4 Jul 2020 02:07:06 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Sat, 04 Jul 2020 02:07:06 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 8143C4265A32; Sat, 4 Jul 2020 02:07:06 +0200 (CEST) Date: Sat, 4 Jul 2020 02:07:06 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Gaurav Singh Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Jakub Kicinski , "open list:NETFILTER" , "open list:NETFILTER" , "open list:NETWORKING [IPv4/IPv6]" , open list Subject: Re: [PATCH] [net/ipv6] Remove redundant null check in ah_mt6 Message-ID: <20200704000706.GA32604@salvia> References: <20200625023626.32557-1-gaurav1086@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200625023626.32557-1-gaurav1086@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gaurav, On Wed, Jun 24, 2020 at 10:36:25PM -0400, Gaurav Singh wrote: > ah cannot be NULL since its already checked above after > assignment and is being dereferenced before in pr(). > Remove the redundant null check. Could you collapse all your patches into one? They look like the same logic change (patch description is the same in the four patches in the series). Please, prepend netfilter: to your patch subject, I suggest the following subject for the collapsed patch. netfilter: ip6tables: Remove redundant null checks Thanks.