Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Sat, 04 Jul 2020 10:48:57 +0100
From:   Marc Zyngier <maz@kernel.org>
To:     Valentin Schneider <valentin.schneider@arm.com>
Cc:     linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH 0/2] genirq: Kill preflow handlers
In-Reply-To: <20200703155645.29703-1-valentin.schneider@arm.com>
References: <20200703155645.29703-1-valentin.schneider@arm.com>
User-Agent: Roundcube Webmail/1.4.5
Message-ID: <6d902159f1819b6f3a0af5e982d11868@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Valentin,

On 2020-07-03 16:56, Valentin Schneider wrote:
> Hi,
> 
> while strolling around the different flow handlers, I tried to make 
> sense of
> what preflow_handler() was about. Turns out no one uses those anymore, 
> but the
> genirq support has remained in place.

If we needed to reintroduce some form of preflow handler, we'd try and
do it using hierarchical irqchips, if at all possible.

> 
> Unless we can see another user of those in the near future, this seems 
> like as
> good a time as any for a little housecleaning.
> 
> - Patch 1 simply deselects the (unexploited) preflow Kconfig for 
> sparc64
> - Patch 2 is the actual cleanup
> 
> Cheers,
> Valentin
> 
> Valentin Schneider (2):
>   sparc64: Deselect IRQ_PREFLOW_FASTEOI
>   genirq: Remove preflow handler support
> 
>  arch/sparc/Kconfig         |  1 -
>  include/linux/irqdesc.h    | 15 ---------------
>  include/linux/irqhandler.h |  1 -
>  kernel/irq/Kconfig         |  4 ----
>  kernel/irq/chip.c          | 13 -------------
>  5 files changed, 34 deletions(-)

For the whole series, and assuming that there is no regression
(can't imagine any for unused code):

Reviewed-by: Marc Zyngier <maz@kernel.org>

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...