Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2997928ybt; Sat, 4 Jul 2020 03:29:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVk78V+fCeAFP2bTPEMPIeJhXw622UApZGtJaaillemlcva4xoNGadKaO9ISiJpf9kzr3l X-Received: by 2002:a50:a881:: with SMTP id k1mr44128638edc.12.1593858560688; Sat, 04 Jul 2020 03:29:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593858560; cv=none; d=google.com; s=arc-20160816; b=bjAEV1bVaTYqDnb9az+VifZVK65izdDDONgmxt0Nitgn06Rq5vZJt005OBBUkHSN6t mUqPF5p1OJPSvj66N/OtYH1bruIW7SdEdCYENqjUsKoGn1qB68NvQdqqqgdpwdV/biT8 Xy516ClHUJBolK8B3JJ4qJquv4FuG5SjgbotgKgRjDX6JUzlqDeQ+62JiCu5felL15MO sMRasOxSnfHa4Ms/ynrP662lTp36/rtz7Vu/slODzaUZvrt3mbeTCwkeScqWEtQW6Cgt hJTkkvtUPdAamnyHWppNLvXEfTtLcNC/2aF1Z8dXADQyjrZJocZYpYXCHLRma4w4ynmU vC4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=d6MVUUUiUZ/bhtH2VAQ03gjFBPUDLQ1YkvRus2a1Mlo=; b=nYIe8L8WgLX5zpntiCUuuQOMDJDsCTZu/XKFTyM5B3e2nYiAUAU9SgpycoaJWgMIJU 48iTsOLvCF9YIQO06ISlXGZDA3e35FI4r66wzahkWH3Lam0n28yXiKfTFiH+cRR83mzc jWq3Ai8822TdJ/aazqbNxTC4Z+47qD7OQdzwF3K50PYhO4rRCZYHhC7EhBrfnfzq94mZ o63XVbdgLORu4Gx1LiRFw/cDjOnNdYPBiW0jFCx23IqmQCLyxo42hkGhGrFqCK0OJXw+ m3TtBOrzIbw/c3gxVv3y+G3rszciMd2Rhj0SXaW/LHQR9qhlca9pXUkLVziAr95p/fzg jHWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XiWxA3m3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw22si9478778ejb.61.2020.07.04.03.28.57; Sat, 04 Jul 2020 03:29:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XiWxA3m3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727083AbgGDK2w (ORCPT + 99 others); Sat, 4 Jul 2020 06:28:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726178AbgGDK2v (ORCPT ); Sat, 4 Jul 2020 06:28:51 -0400 Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C55EC061794 for ; Sat, 4 Jul 2020 03:28:51 -0700 (PDT) Received: by mail-il1-x141.google.com with SMTP id a6so12410401ilq.13 for ; Sat, 04 Jul 2020 03:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=d6MVUUUiUZ/bhtH2VAQ03gjFBPUDLQ1YkvRus2a1Mlo=; b=XiWxA3m31JFaQ+mz5kCbQf2IwRGT6mUu1B/lZblRXRO8IlLsbz/OnJy0/frpHJ/CV0 LIdILgFdp5R0ARxu3Rh4n6BNeCyylUo72QIrg1zKCp0Tb6SDEjonSX4i8UIfwY4cuaKu mDiiggfIuCRigMOAV3FNhhMEvKPFhZYOGHgvdWQezTeoayDm9xvl8/T8wWojPAswvqt8 osbSGPR52diaqebXjARk2VnefI/2NKhE+DC0yBudXPgoXml5BC21gsPT744DlJl7uPBv 7mmHdHP/jXe4gA0SliOy1tto4JUr4iX4sQUbpv6D4JgJWZ3IgefHX1mAKaanraTlIEdr Nu2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=d6MVUUUiUZ/bhtH2VAQ03gjFBPUDLQ1YkvRus2a1Mlo=; b=cS8nkdM8KeyYkJNfKqPpIzYWa7Udy1nfyPXzw9Yz9QKGwcNmyQaIm8edRd35mvIf7a k4fBT/e/elVFEpRTEGvCCgEstK9h61OYTdR9Wpo77N4e51v2zwXkFetGlgmMYL0v+6Ef l12jutbSL85gBBubYSLgnWcQjePAvE4XfkwjKXKxidFWn/l482ipe2t8xxQK1czhblzA Tb5TwCLvlBCd1l3+HKS4I9MVDqAIiRI1N5ga7fs9+Pmg00Nzjfm8UKhiyMDMYwkbyLn4 pze331KTY4mzDHBMnDcdk6T1sJY9DJsM9jV6vWlNdUhgVPT1A9v6Wn/w5iMRkS8ceYpI gz8w== X-Gm-Message-State: AOAM530NNFq1ChyFBepZoDDxOi3TekU5GAu0LCsSS24edpguWIc36feB WNnLuTbNtqOU4RK/M84+WhcmWYoE/1rTgUkOpSs= X-Received: by 2002:a92:4b08:: with SMTP id m8mr20423899ilg.150.1593858530565; Sat, 04 Jul 2020 03:28:50 -0700 (PDT) MIME-Version: 1.0 References: <20200704102535.189647-1-peron.clem@gmail.com> In-Reply-To: <20200704102535.189647-1-peron.clem@gmail.com> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Sat, 4 Jul 2020 12:28:39 +0200 Message-ID: Subject: Re: [PATCH v2 00/14] Add regulator devfreq support to Panfrost To: Rob Herring , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , Viresh Kumar , Nishanth Menon , Stephen Boyd , Maxime Ripard , Chen-Yu Tsai Cc: dri-devel , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, 4 Jul 2020 at 12:25, Cl=C3=A9ment P=C3=A9ron = wrote: > > Hi, > > This serie cleans and adds regulator support to Panfrost devfreq. > This is mostly based on comment for the freshly introduced lima > devfreq. > > We need to add regulator support because on Allwinner the GPU OPP > table defines both frequencies and voltages. > > First patches [01-07] should not change the actual behavior > and introduce a proper panfrost_devfreq struct. > > Regards, > Cl=C3=A9ment Changes since v1: - Collect Steven Price reviewed-by tags - Fix spinlock comment - Drop OPP clock-name path - Drop device_property_test patch - Add rename error labels patch > > Cl=C3=A9ment P=C3=A9ron (14): > drm/panfrost: avoid static declaration > drm/panfrost: clean headers in devfreq > drm/panfrost: don't use pfdevfreq.busy_count to know if hw is idle > drm/panfrost: introduce panfrost_devfreq struct > drm/panfrost: use spinlock instead of atomic > drm/panfrost: properly handle error in probe > drm/panfrost: rename error labels in device_init > drm/panfrost: move devfreq_init()/fini() in device > drm/panfrost: dynamically alloc regulators > drm/panfrost: add regulators to devfreq > arm64: defconfig: Enable devfreq cooling device > arm64: dts: allwinner: h6: Add cooling map for GPU > [DO NOT MERGE] arm64: dts: allwinner: h6: Add GPU OPP table > [DO NOT MERGE] arm64: dts: allwinner: force GPU regulator to be always > > .../dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 + > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 102 +++++++++++ > arch/arm64/configs/defconfig | 1 + > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 165 ++++++++++++------ > drivers/gpu/drm/panfrost/panfrost_devfreq.h | 30 +++- > drivers/gpu/drm/panfrost/panfrost_device.c | 61 ++++--- > drivers/gpu/drm/panfrost/panfrost_device.h | 14 +- > drivers/gpu/drm/panfrost/panfrost_drv.c | 15 +- > drivers/gpu/drm/panfrost/panfrost_job.c | 10 +- > 9 files changed, 290 insertions(+), 109 deletions(-) > > -- > 2.25.1 >