Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <72aa9cf8c9bc46548c29742f55be7d3b0c002971.camel@archlinux.org>
Subject: Re: [PATCH v3] HID: logitech-hidpp: add support for Logitech G533
 headset
From:   Filipe =?ISO-8859-1?Q?La=EDns?= <lains@archlinux.org>
To:     Kamil =?UTF-8?Q?Doma=C5=84ski?= <kamil@domanski.co>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-kernel@vger.kernel.org
Cc:     Nestor Lopez Casado <nlopezcasad@logitech.com>
In-Reply-To: <20200704004745.383271-1-kamil@domanski.co>
References: <20200704004745.383271-1-kamil@domanski.co>
Organization: Archlinux
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-GdT9r/VywNZa2Mspbe4R"
Date:   Sat, 04 Jul 2020 16:01:43 +0100
MIME-Version: 1.0
User-Agent: Evolution 3.36.4 
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-GdT9r/VywNZa2Mspbe4R
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 2020-07-04 at 02:47 +0200, Kamil Doma=C5=84ski wrote:
> Changelog:
>   v2:
>   - changed charging status parsing to account for invalid states
>   v3:
>   - rebased against Linux v5.7
>   - changed variable naming in hidpp20_adc_map_status_voltage
>     to camel case
>   - corrected comment styling in hidpp_battery_get_property
>   - dropped usage of test_bit macro in hidpp20_adc_map_status_voltage
>     to avoid using `long` type
>   - added bit flag definitions in hidpp20_adc_map_status_voltage
>=20
> Signed-off-by: Kamil Doma=C5=84ski <kamil@domanski.co>

Seems like my concerns were address and the patch looks correct.

Benjamin, Jiri, are there any implications to keep in mind of always
polling the device every time we need to read the voltage? I don't
expect anything major, I just thought there might something there I
should keep in the back of my mind.=20

Cheers,
Filipe La=C3=ADns

--=-GdT9r/VywNZa2Mspbe4R
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0jW0leqs33gyftiw+JPGdIFqqV0FAl8Amc0ACgkQ+JPGdIFq
qV2UYQ//RszgLx10wEQNOJcwL2CzwReRT3sHGA8Cjx26fCzqvgofQ7lLBgdrdsIM
WgYzFiDY6Q9r9Q+P0ZrUlpvOQES2OnA/7kYY9ViydF+sy4fH8LIUciISzVTsvO7i
YYGRgln5ufeZ3d6McoHvnfjezOYXstGPpcFdGGgCFqk1dmKZ85crDr2Ql9LrbAeB
of8Lv8IzNwZG8J6q2hHmD5KZV4b/XASsWSyR7zKd17A3EPOfE0vC0IvSKWEveegM
pnSau/uC9YvSKAZqCyK/WEmCu3L2GqI9GX0WxAzK5jpoxKfYLDk0l4VJfGPHJgyr
ck1YLhDM8cvQKY/DVkbLrN9dQbcYFDZj6rfOOKxaw+028qrRCJ1I95mvG06wfa2B
Vbf5gAyv1fe5mrZIGuXR2ksSdKFJpebIzwSNwTtbhr9xTkduA7ZyNH8ovJEvyjIo
dl8b7LKuutOh/ssB6/zx7yWOWLxmHpBTGaBvJm0g96+cfufLD81Li6PKLbFTAEDc
yIh9OElKD1JWLdYYucgiMHbplUDzVTBuyZZjs9yOwDZwrFZqqvuKUCrEdQCUS8+1
m+LSDcr473w5i7vsgh4NEAZz8w/9tIfyxOyTaakBBdGJrpP5fBhI5conQWEHCYld
kyYlH/iO5df/7tQWLJqifQE+Hns7WbESReFidcIZEF5ozll4AtI=
=8KEs
-----END PGP SIGNATURE-----

--=-GdT9r/VywNZa2Mspbe4R--