Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200704195116.19669-1-oshpigelman@habana.ai>
In-Reply-To: <20200704195116.19669-1-oshpigelman@habana.ai>
From:   Oded Gabbay <oded.gabbay@gmail.com>
Date:   Sun, 5 Jul 2020 00:39:04 +0300
Message-ID: <CAFCwf12WXAnVA1mTCxiifG7npi4hVJquPvC_NTG-9c4Gyc+u1A@mail.gmail.com>
Subject: Re: [PATCH] habanalbas: rephrase error message
To:     Omer Shpigelman <oshpigelman@habana.ai>
Cc:     "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Jul 4, 2020 at 10:51 PM Omer Shpigelman <oshpigelman@habana.ai> wrote:
>
> Rephrase F/W error message to make it more understandable to ordinary
> users.
>
> Signed-off-by: Omer Shpigelman <oshpigelman@habana.ai>
> ---
>  drivers/misc/habanalabs/firmware_if.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/firmware_if.c b/drivers/misc/habanalabs/firmware_if.c
> index baf790cf4b78..171baa2b56b0 100644
> --- a/drivers/misc/habanalabs/firmware_if.c
> +++ b/drivers/misc/habanalabs/firmware_if.c
> @@ -566,7 +566,8 @@ int hl_fw_init_cpu(struct hl_device *hdev, u32 cpu_boot_status_reg,
>                                 "Device reports FIT image is corrupted\n");
>                 else
>                         dev_err(hdev->dev,
> -                               "Device failed to load, %d\n", status);
> +                               "Failed to load firmware to device, %d\n",
> +                               status);
>
>                 rc = -EIO;
>                 goto out;
> --
> 2.17.1
>

This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>