Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3446222ybt; Sat, 4 Jul 2020 18:03:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiumeDWhLHlEUu4EJGaTtEbbAN8kXuoLdZ8sSKO7FoemrefUzapiKHLWUoXp5SQaqZIrKf X-Received: by 2002:a17:906:1c0d:: with SMTP id k13mr39643091ejg.477.1593910993620; Sat, 04 Jul 2020 18:03:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593910993; cv=none; d=google.com; s=arc-20160816; b=pra9vQuxc/lWAczwtRrJj7/mRFRP03Gxc1gA5jMy3Etu4djs1FMKRzIntXiklxbzDp NTyP/Vo/PFnI1jGFY3eQcjfqc1XVGxQqVfLOHnjYFWNdPAnxH43mf6UiYAl0C2lPpezb 5XoD2M4qRHbVN6X1modZtt3h3pdtHT2x70Nk7DB75QaXQ7y5Lsckj4yKJ1+rv/x2navs Kvc6WYe1w4ZUKw0Uyuxu/PudBHBMvp5O+ZmROcEE5SPwjAXznytmXAJEcNItfW0drHF8 RxQqwHpUu96MRpZNlWSV6NRujnqebxOlImS1b0mXRdgzANNbd6d3oMVdXNKaX67Ol8AF UVLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=JLsyaYksIRSrRxetFrkntUehLUYv/WnmJ/+UVWQG748=; b=PTqdxKb7ZvSMCVdSB/nHxgmoMKG9jLWudOG3NYQhN0tNLjoKf9HPQ+8hDWKGcVZpzc sIX09+d9aOaoQfo9ttST+SfUukSg5G7VyXR2+eaC6gScDPMPgYBoolXUSFookOuJaZhq PRH+ZWze+k/ekimrEM2DXf7mpec8FzkTP+z/lMTgYP0IzvUoKDOGTcjwzTSmNyBOkfJt tTOxdYfcin/YIMIRt8SC4gpeejlrr2XpDfuSb/iMr4JlB6FHRXvHb3kqXSM85jVWpF79 eAn7UuReRJyw8rXPQx8PzTHvU806CuyFLpqWhL7sa0Dz6o2Qe4D2RE3402I3tkJGErpO W5Rg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu2si10577998edb.423.2020.07.04.18.02.51; Sat, 04 Jul 2020 18:03:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728143AbgGEBCX (ORCPT + 99 others); Sat, 4 Jul 2020 21:02:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727041AbgGEBCW (ORCPT ); Sat, 4 Jul 2020 21:02:22 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0D84C061794; Sat, 4 Jul 2020 18:02:22 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6ACB4157A9DB7; Sat, 4 Jul 2020 18:02:21 -0700 (PDT) Date: Sat, 04 Jul 2020 18:02:20 -0700 (PDT) Message-Id: <20200704.180220.228881421138550916.davem@davemloft.net> To: vaibhavgupta40@gmail.com Cc: helgaas@kernel.org, bhelgaas@google.com, bjorn@helgaas.com, vaibhav.varodek@gmail.com, kuba@kernel.org, manishc@marvell.com, rahulv@marvell.com, GR-Linux-NIC-Dev@marvell.com, shshaikh@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org Subject: Re: [PATCH v2 0/2] qlogic: use generic power management From: David Miller In-Reply-To: <20200702170143.27201-1-vaibhavgupta40@gmail.com> References: <20200702170143.27201-1-vaibhavgupta40@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 04 Jul 2020 18:02:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vaibhav Gupta Date: Thu, 2 Jul 2020 22:31:41 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management callbacks > from qlogic ethernet drivers. > > The callbacks performing suspend() and resume() operations are still calling > pci_save_state(), pci_set_power_state(), etc. and handling the power management > themselves, which is not recommended. > > The conversion requires the removal of the those function calls and change the > callback definition accordingly and make use of dev_pm_ops structure. > > All patches are compile-tested only. > > V2: Fix unused variable warning in v1. Series applied.