Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3487859ybt; Sat, 4 Jul 2020 19:51:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx517tdPNIAs53ZNWahvZjR08ckAuCGCoDEe699HGKc3LJAAOJpdn8LxiVuBXFF4k/qpq4B X-Received: by 2002:a17:906:eb4b:: with SMTP id mc11mr37709168ejb.5.1593917465539; Sat, 04 Jul 2020 19:51:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593917465; cv=none; d=google.com; s=arc-20160816; b=DdEtAsyqS1gOaJ0BH+/WTbUVrixLK0bh1p1qfM6L3vDlidlnlRubO9cpW5gbtK/sOX lDRq56cj8qJLFdyn/++SE+HUXOmALWgxVZvNBpr8c5qG7bwlVkGQIfWV3BEYbq+jNxJq f45uwALxsioNHiN2Y1hUY56QIZia0DtO0TzgGWHkGxtiadCfhkBO2SmBZvOJwiKR4B5w IU7Y+W1j/ALpA5+qHM8ms7UJ3DamDpnUeIYrtrOr6DWNvuZ06bt4S8dU87KnJV7jl3t8 JXZSnbiEYn41BdZbXjKNdmlpHn8WPDQPNz8jmk87RyKLA0Q4FSOsx1qgmxmTVQAhQcAv 89NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:subject:reply-to:from:to:dkim-signature:date; bh=pmMW5RuvGxW1tpO1VhOI282KLL4Jyl1FTQA9xHHkje0=; b=TpSRuqMbrXQ2mvI3q7XDmux1dLXe4soMCtoEKD4HL9BQj2b8e9v3BBD3xcF2VzJVu2 zaevYrRWWY24s58EnyijALHzCtXEe5NvMdF2XiBJEmJtNjVzyfDY8M6vHwoW2DaJODDV 6oy78RQWZP3sKUzNi3amOdB4ougMQ3bMDOk7qVXr5yIWX2jRzjci6mMdgvhs4kxZ58pc n4sGXcT/ZBepnkXbJA5MW5It1xHP97p1WYFVcChvlHjxTHlwI27PCxRKl0mFObVoNMcV zIP8B610BAsAm1TplpMf2JVNAqZdSv95za95cZnrZ2wyf6Rgxp1WDJlPF+v1wtUIMa+A 0m+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail header.b=DRV+xQmi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q8si10215070ejt.753.2020.07.04.19.50.42; Sat, 04 Jul 2020 19:51:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail header.b=DRV+xQmi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728166AbgGECsZ (ORCPT + 99 others); Sat, 4 Jul 2020 22:48:25 -0400 Received: from mail-40135.protonmail.ch ([185.70.40.135]:45801 "EHLO mail-40135.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728004AbgGECsZ (ORCPT ); Sat, 4 Jul 2020 22:48:25 -0400 Date: Sun, 05 Jul 2020 02:48:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1593917302; bh=pmMW5RuvGxW1tpO1VhOI282KLL4Jyl1FTQA9xHHkje0=; h=Date:To:From:Reply-To:Subject:From; b=DRV+xQmisuiAsx1+Yha2dlCbDHytWWCnUPz0BqGWq+248/rATeQ+YR+wM2wyy+cVb coT2B9en+mgxOKUFdNKenoVW4CKQ9Q3czSpS/uCksg5QtgTMck0Tl4IY8Wn5LesWeC vY4tfGQgEokDWfOLTibNNYo8ByXWON5Ex4KcpnRs= To: "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jikos@kernel.org" , Benjamin Tissoires From: Mazin Rezk Reply-To: Mazin Rezk Subject: [PATCH] HID: logitech: Use HIDPP_RECEIVER_INDEX instead of 0xff Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HK_RANDOM_REPLYTO shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some parts of hid-logitech-dj explicitly referred to 0xff for the receiver index. This patch changes those references to the HIDPP_RECEIVER_INDEX definition. Signed-off-by: Mazin Rezk --- drivers/hid/hid-logitech-dj.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index 48dff5d6b605..a78c13cc9f47 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -1153,7 +1153,7 @@ static int logi_dj_recv_query_paired_devices(struct d= j_receiver_dev *djrcv_dev) =09if (!dj_report) =09=09return -ENOMEM; =09dj_report->report_id =3D REPORT_ID_DJ_SHORT; -=09dj_report->device_index =3D 0xFF; +=09dj_report->device_index =3D HIDPP_RECEIVER_INDEX; =09dj_report->report_type =3D REPORT_TYPE_CMD_GET_PAIRED_DEVICES; =09retval =3D logi_dj_recv_send_report(djrcv_dev, dj_report); =09kfree(dj_report); @@ -1175,7 +1175,7 @@ static int logi_dj_recv_switch_to_dj_mode(struct dj_r= eceiver_dev *djrcv_dev, =09if (djrcv_dev->type =3D=3D recvr_type_dj) { =09=09dj_report->report_id =3D REPORT_ID_DJ_SHORT; -=09=09dj_report->device_index =3D 0xFF; +=09=09dj_report->device_index =3D HIDPP_RECEIVER_INDEX; =09=09dj_report->report_type =3D REPORT_TYPE_CMD_SWITCH; =09=09dj_report->report_params[CMD_SWITCH_PARAM_DEVBITFIELD] =3D 0x3F; =09=09dj_report->report_params[CMD_SWITCH_PARAM_TIMEOUT_SECONDS] =3D @@ -1204,7 +1204,7 @@ static int logi_dj_recv_switch_to_dj_mode(struct dj_r= eceiver_dev *djrcv_dev, =09memset(buf, 0, HIDPP_REPORT_SHORT_LENGTH); =09buf[0] =3D REPORT_ID_HIDPP_SHORT; -=09buf[1] =3D 0xFF; +=09buf[1] =3D HIDPP_RECEIVER_INDEX; =09buf[2] =3D 0x80; =09buf[3] =3D 0x00; =09buf[4] =3D 0x00; -- 2.27.0