Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make
 savedefconfig`
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20200702111200.39997-1-pmenzel@molgen.mpg.de>
 <CAK7LNAR7=NCsJ5irVUCStkfCLt0d=R5AX6cEwc9z=b_-V=-0Ng@mail.gmail.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
Message-ID: <59a4efc5-f6cb-f00a-fa83-bc7658ca1463@molgen.mpg.de>
Date:   Sun, 5 Jul 2020 09:19:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAK7LNAR7=NCsJ5irVUCStkfCLt0d=R5AX6cEwc9z=b_-V=-0Ng@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Dear Masahiro,


Am 05.07.20 um 09:14 schrieb Masahiro Yamada:
> On Thu, Jul 2, 2020 at 8:12 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>>
>> Running `make savedefconfig` creates by default `defconfig`, which is,
>> currently, on git’s radar, for example, `git status` lists this file as
>> untracked.
>>
>> So, add the file to `.gitignore`, so it’s ignored by git.
>>
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
>> ---
>>   .gitignore | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 87b9dd8a163b..f07500889fba 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -143,6 +143,9 @@ x509.genkey
>>   /allrandom.config
>>   /allyes.config
>>
>> +# Kconfig presets, default savedefconfg output
> 
> 
> I just noticed this comment is wrong
> since 'defconfig' is not a preset.
> 
> I will change it to 'Kconfig savedefconfig output'.

Thank you for finding my error and correcting it.

I couldn’t find out more about *presets*.

     $ git grep -i preset scripts/kconfig/
     $

Where can I look, so I won’t repeat the same mistake next time?

>> +/defconfig
>> +
>>   # Kdevelop4
>>   *.kdev4
>>
>> --
>> 2.27.0

Kind regards,

Paul