To: Christoph Hellwig <hch@infradead.org>
Cc: openib-general@openib.org, linux-kernel@vger.kernel.org
Subject: Re: [openib-general] updated InfiniBand 2.6.17 merge plans
References: <ada7j6f8xwi.fsf@cisco.com> <ada1wwj1r7r.fsf@cisco.com>
	<adawtebzfxm.fsf@cisco.com> <20060331063239.GA31436@infradead.org>
From: Roland Dreier <rdreier@cisco.com>
Date: Fri, 31 Mar 2006 08:36:57 -0800
In-Reply-To: <20060331063239.GA31436@infradead.org> (Christoph Hellwig's message of "Fri, 31 Mar 2006 07:32:39 +0100")
Message-ID: <adaodzmzi3a.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1137
Lines: 28

    Roland> * Get rid of option for building IPoIB and mthca debug
    Roland> output unless EMBEDDED=y

    Christoph> NACK.  Just add a FOO_DEBUG config option, this has
    Christoph> no?hing to do with EMBEDDED.

I think you misunderstood (probably because what I wrote was very
unclear).  What I meant to say was that I wanted to make
CONFIG_INFINIBAND_IPOIB_DEBUG=y, without the option to disable it,
unless CONFIG_EMBEDDED is set.  In Kconfig language, change it to:

	config INFINIBAND_IPOIB_DEBUG
		bool "IP-over-InfiniBand debugging" if EMBEDDED
		depends on INFINIBAND_IPOIB
		default y

Do you still have a problem with that?  The rationale is that we want
the debugging output compiled in (it still needs to be enabled at
runtime) unless the user really really knows they don't want it,
because by the time we know we want the output, it's too late to
recompile to kernel.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/