Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3787716ybt; Sun, 5 Jul 2020 06:54:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIdTQpH1BN5bW41ppqyV6txIwggfXRTpN0FmZ0urLW++xOWMdqU+8BU+FhKj4bMpFbWOPJ X-Received: by 2002:a50:8a62:: with SMTP id i89mr36828371edi.324.1593957243038; Sun, 05 Jul 2020 06:54:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593957243; cv=none; d=google.com; s=arc-20160816; b=RFW1AU7BN+CutyypKrEm8NF3H1u767cgifdHPK+uur9bTP2N2BO+In8eM6dj4RWguj CGVegJKnolKBURm4pcz1UUp0tJ1cx9jme+43y3qlV6DLccUqvl9z4vzUo5x8d0CkLCnX Q+1cx0pwohNNcK+4bHdt8uS9k+d7VmNJkQYZj74RhZziXDgMANCPDQjr/XWkYMrwD909 +DGupILm8MOyUUO2qLLPrSIUPpVt4Pi3kNNV7qGujUe6fY0HT5ryGjoZBCjRxK+YLcb5 pp6vV8q+il8zm/yUitOKaw0SUCCmq3Dk+DIxdT54jajB/QFg4kSKy5J5DD6l5NTe39oO vdDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=Zvrrr/jCdVtqukzvrk9NHKvKUQCbdo2phy68HZUCPiA=; b=nXY6Z88DB+iUwt+rIazNdwtHqpUDPpM8YR/BWbWFYJtFkpsErU6Cm5aNobMMbEooWn dYXqEOJgO0Lu9pS5bR1TOf0769ex2rlMfhdwPFytocOyuEuIrCZcUwQnJ9RifB9r8UtM 7BXx+34qmTc9AshfG/2sn12/tApaDuT71fa2mGHwBszUid6dg0EQV2yoBB/q2+Qu06Lg mampOOoFn9x0P/bXOi1wmKqeLsTX0buIoGcJODJTMuJn+s7L/Vp1qLIcD/tc85EH7SxZ ACGVIqdsGIY84Ks4nKZZz7LGv9Y1gYAf+4geXv9DkkG1v2Vm8123bXuAeg0U3Y9C5DBP VCQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@es-iitr-ac-in.20150623.gappssmtp.com header.s=20150623 header.b=g1MDiuJ2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=iitr.ac.in Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de19si12073239edb.285.2020.07.05.06.53.38; Sun, 05 Jul 2020 06:54:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@es-iitr-ac-in.20150623.gappssmtp.com header.s=20150623 header.b=g1MDiuJ2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=iitr.ac.in Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727052AbgGENx2 (ORCPT + 99 others); Sun, 5 Jul 2020 09:53:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726833AbgGENx1 (ORCPT ); Sun, 5 Jul 2020 09:53:27 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF6EFC08C5DE for ; Sun, 5 Jul 2020 06:53:24 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id bj10so9098251plb.11 for ; Sun, 05 Jul 2020 06:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=Zvrrr/jCdVtqukzvrk9NHKvKUQCbdo2phy68HZUCPiA=; b=g1MDiuJ23X0nii/rFRT2Hzg6WO7+PSVHLhMc6XTp62YJD9yA+bhg61khgfMKZ6Wfo5 u/zIS8CW2tw1JV/Ijd8AFYgvw2r+yM3fGVRYjT2qaPnUZbLa4aCQrKpL0YhNPh/ocylg rAir8Ja7fIiSFRLgibpK9Et3VE1Q14V3bRkCPV1j4LfCQxj98cMR83R0HBG5qDPq8oO+ GdxnXtd1fwcfeVbVKNHwPzCi5BtvunA0T16ti2JepTuqy3ouSopdY3oqDoUOSdIhHReW Vn0rTvddMiZ3+79XQUazTSl/F0Et8ChPWygNVNtOowUoczHyfNADWTyBzTmChA4ee4SC bxVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Zvrrr/jCdVtqukzvrk9NHKvKUQCbdo2phy68HZUCPiA=; b=YRi/pxJQ5RnZVCXKF9OnPD8CMrucFDGjKUfZOXZjEh4haP5F+WXVkuZDE3wX+SDhBw qt+/hCN59nGPJ+lKDAhjg08L1OMUr0ctmV5RL9olXVZ00Yl4cpBVo3RhngLzRGiCfSjv RUJNPSc6CMaafr482vOZ22hipJWcm9e0Mb53dHFyAn2ZDNX12T2CmlNUBK4YDKk5q+Qm Ll96L9kCLDsdxckWehgqUsKuymFMXovBRsa2hzEPnNr6TmfljUw7HSAwY9YFvZsCXuS2 6vQGnHjSLHmVMUw/69V5Aa7wCvQ82bcs7OQJVnVa37JC3syP04ixZ3VZZjRAOGkdlghM cAnw== X-Gm-Message-State: AOAM532eZdX+tk8DfDg8M6oK0khfFGvN8m5enD+seWLIm45Lrw0IJyrK u8vyN+20je8QmH6Dw6olEW5QRQ== X-Received: by 2002:a17:90a:254f:: with SMTP id j73mr36672053pje.16.1593957204192; Sun, 05 Jul 2020 06:53:24 -0700 (PDT) Received: from kaaira-HP-Pavilion-Notebook ([103.113.213.178]) by smtp.gmail.com with ESMTPSA id f14sm16560916pgj.62.2020.07.05.06.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2020 06:53:23 -0700 (PDT) From: Kaaira Gupta To: Helen Koike , Shuah Khan , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Kieran Bingham Cc: Kaaira Gupta Subject: [PATCH v10 0/3] media: Add colors' order and other info over test image Date: Sun, 5 Jul 2020 19:23:03 +0530 Message-Id: <20200705135307.27564-1-kgupta@es.iitr.ac.in> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patchset aims to add a method to display the correct order of colors for a test image generated. It does so by adding a function which returns a string of correct order of the colors for a test pattern. It then adds a control in vimc which displays the string over test image. It also displays some other information like saturation, hue, contrast brightness and time since the stream started over test image generated by vimc. Changes since v9: In patch 3: - Use div_u64() instead of "/" to divide a u64 divident with a constant (u32) Changes since v8: In patch 1: - Add more details to commit message. In patch 3: - Formatting nits. Changes since v7: In patch 3: - Use fallthrough; to indicate a fall through in switch-case - Use enum type instead of int for osd_value - Change varaible to osd_value instead of osd_mode as the enum osd_mode defines the modes. Changes since v6: In patch 3: - Use switch case instead of if() - reorder declarartions. Changes since v5: In patch 2: - Add missing EXPORT_SYMBOL_GPL() In patch 3: - Renamed varaibles. - use u64 instead of int for getting current time in nanoseconds. - Use enum instead of numbers to describe the state of osd_mode control in code. Changes since v4: - Add another patch which changes char argument to const char in function tpg_gen_text() - Return const char * from function tpg_g_color_order() in patch 2 In 3rd patch: - Check font in probe() instead of s_stream() - Use dev_err instead of pr_err - Fix errors in commit message. - Base VIMC_CID_SHOW_INFO on VIVID_CID_OSD_TEXT_MODE Changes since v3: In 1st patch: -Improved formatting of returned string. In 2nd patch: - Add CID prefix in control name and change it to a more generic name. - Rename bool variable to a generic name. - Disable text rendering instead of stopping stream if no font found. - Display more info like VIVID in VIMC. Changes since v2: In 1st patch: - Create a 'define' to prevent repetition of the common color sequence string. - Use 'fallthrough' on case statement to prevent repetition of code. Changes since v1: - Divided the patch into two patches. - Returned NULL for patterns whose color order cannot be defined. (Reported-by: kernel test robot ) - Made separate switch cases for separate test patterns (Reported-by: kernel test robot ) - Renamed variables from camelcase to use '_' - prefixed 'media' to the patches. Kaaira Gupta (3): media: tpg: change char argument to const char media: tpg: Add function to return colors' order of test image media: vimc: Add a control to display info on test image drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 40 +++++++++-- drivers/media/test-drivers/vimc/Kconfig | 2 + drivers/media/test-drivers/vimc/vimc-common.h | 1 + drivers/media/test-drivers/vimc/vimc-core.c | 10 +++ drivers/media/test-drivers/vimc/vimc-sensor.c | 71 +++++++++++++++++++ include/media/tpg/v4l2-tpg.h | 3 +- 6 files changed, 119 insertions(+), 8 deletions(-) -- 2.17.1