Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200702111200.39997-1-pmenzel@molgen.mpg.de> <CAK7LNAR7=NCsJ5irVUCStkfCLt0d=R5AX6cEwc9z=b_-V=-0Ng@mail.gmail.com>
 <59a4efc5-f6cb-f00a-fa83-bc7658ca1463@molgen.mpg.de>
In-Reply-To: <59a4efc5-f6cb-f00a-fa83-bc7658ca1463@molgen.mpg.de>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Mon, 6 Jul 2020 00:34:52 +0900
Message-ID: <CAK7LNAS8pTFfhHb_Z+Hh5LWZ2DCCzfGtTq4oizykOYb_QRqgMw@mail.gmail.com>
Subject: Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jul 5, 2020 at 4:19 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Masahiro,
>
>
> Am 05.07.20 um 09:14 schrieb Masahiro Yamada:
> > On Thu, Jul 2, 2020 at 8:12 PM Paul Menzel <pmenzel@molgen.mpg.de> wrot=
e:
> >>
> >> Running `make savedefconfig` creates by default `defconfig`, which is,
> >> currently, on git=E2=80=99s radar, for example, `git status` lists thi=
s file as
> >> untracked.
> >>
> >> So, add the file to `.gitignore`, so it=E2=80=99s ignored by git.
> >>
> >> Cc: linux-kernel@vger.kernel.org
> >> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> >> ---
> >>   .gitignore | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/.gitignore b/.gitignore
> >> index 87b9dd8a163b..f07500889fba 100644
> >> --- a/.gitignore
> >> +++ b/.gitignore
> >> @@ -143,6 +143,9 @@ x509.genkey
> >>   /allrandom.config
> >>   /allyes.config
> >>
> >> +# Kconfig presets, default savedefconfg output
> >
> >
> > I just noticed this comment is wrong
> > since 'defconfig' is not a preset.
> >
> > I will change it to 'Kconfig savedefconfig output'.
>
> Thank you for finding my error and correcting it.
>
> I couldn=E2=80=99t find out more about *presets*.
>
>      $ git grep -i preset scripts/kconfig/
>      $
>
> Where can I look, so I won=E2=80=99t repeat the same mistake next time?


You can find 'preset' in
Documentation/kbuild/kconfig.rst
but it does appear in the source files.


--=20
Best Regards
Masahiro Yamada