Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3948361ybt; Sun, 5 Jul 2020 11:31:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxP7an9ibIY0pIXkf4/O4mqMWm6RevrNNV0LVI3sT/UcHYTcB59XqfW79BVv66MlWCRnDMx X-Received: by 2002:a17:906:cd18:: with SMTP id oz24mr40428645ejb.118.1593973900115; Sun, 05 Jul 2020 11:31:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593973900; cv=none; d=google.com; s=arc-20160816; b=mAYSEaFy7MYo5x7qJ4TFON2mkcygzfH+EsOoXN+9PN/7N6C/JxB6QKbc65qKz9opZe 5Hpel51BqplYzLcs9SWqszeAVI6H/Dixtno3EIWOzpxtXnTnAMTwaSvMODN9msRhspS/ HTlEeKSLf2669laJwZY21803nNxmzabOG8NCjDpIrcZmhTTCQuAVJEUuEMAU9wcqwJsL GMFMG6nuH39HFP7GINiwNEyKLV7O8UI4nMtWZByFNozRoBStlaM7UNIFZtB1/nHWhwC8 M4Z+Y2yg0p+wTZ9iCdvcuFK9U0HkcPR6R0G9vh3ju2U79sKM6z/HVl1chnhTEpVHZ7NS zQVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=w78RAUl3xjXL4g8wMj+6XH9MYScK5pg+WbKTF7DkPSY=; b=EhO1BLopq1OGbI4wHuGIz5jATGpRyjU4tnMlDhAZFpYOCio/91T0ojBAhjY8rFzqtQ i4VMkQ6W0QMqbhT874jZTpyQYnrfgQwjNNlNvgI8HT3UXebuO8ZMInJvY+MklDn78oJ8 mjHseBEwwPEssV2LKJ+bW1F0U1N3Maws/N2AmNZV9ZviwTM8763+QQegCV3z6XoyC/EU H+fTpVFUq0unlx+HpvS6S+HKUhvn76c2EC4k0TqsM61exDXqm8Mu6IlgPYM01kxLLZGR jZRbzwiH+6MvZJ8RK9/5+IfAZE7fuxTR3lyzkZgi1ES5vvGOzhRxWW73ly6nFq/ZyScC VU5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b10si11247229ejv.385.2020.07.05.11.31.16; Sun, 05 Jul 2020 11:31:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728002AbgGESam (ORCPT + 99 others); Sun, 5 Jul 2020 14:30:42 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:58297 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727925AbgGESam (ORCPT ); Sun, 5 Jul 2020 14:30:42 -0400 X-Originating-IP: 212.92.121.187 Received: from localhost (unknown [212.92.121.187]) (Authenticated sender: amit@amitshah.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id B06631BF20A; Sun, 5 Jul 2020 18:30:39 +0000 (UTC) Date: Sun, 5 Jul 2020 20:30:38 +0200 From: Amit Shah To: Rikard Falkeborn Cc: Greg Kroah-Hartman , Arnd Bergmann , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] virtio_console: Constify some static variables Message-ID: <20200703175529.GE3150@trundl.on> References: <20200701200950.30314-1-rikard.falkeborn@gmail.com> <20200701200950.30314-6-rikard.falkeborn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200701200950.30314-6-rikard.falkeborn@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (Wed) 01 Jul 2020 [22:09:50], Rikard Falkeborn wrote: > The id_table and feature_table pointers in struct virtio_driver are > pointers to const. Mark the corresponding static variables const to > allow the compiler to put them in read-only memory. > > Before: > text data bss dec hex filename > 25447 713 76 26236 667c drivers/char/virtio_console.o > > After: > text data bss dec hex filename > 25488 673 76 26237 667d drivers/char/virtio_console.o > > Signed-off-by: Rikard Falkeborn Reviewed-by: Amit Shah Please CC me on the entire series instead of individual patches in the future. Thanks, Amit -- http://amitshah.net/