Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932139AbWCaRkl (ORCPT ); Fri, 31 Mar 2006 12:40:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932145AbWCaRkl (ORCPT ); Fri, 31 Mar 2006 12:40:41 -0500 Received: from mail.parknet.jp ([210.171.160.80]:53511 "EHLO parknet.jp") by vger.kernel.org with ESMTP id S932139AbWCaRkk (ORCPT ); Fri, 31 Mar 2006 12:40:40 -0500 X-AuthUser: hirofumi@parknet.jp To: Andi Kleen Cc: Jes Sorensen , Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org Subject: Re: [patch] avoid unaligned access when accessing poll stack References: <200603311853.32870.ak@suse.de> <87ek0ipmae.fsf@duaron.myhome.or.jp> <200603311918.35207.ak@suse.de> From: OGAWA Hirofumi Date: Sat, 01 Apr 2006 02:40:34 +0900 In-Reply-To: <200603311918.35207.ak@suse.de> (Andi Kleen's message of "Fri, 31 Mar 2006 19:18:34 +0200") Message-ID: <87irpums19.fsf@duaron.myhome.or.jp> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 625 Lines: 16 Andi Kleen writes: >> char stack_pps[POLL_STACK_ALLOC] >> __attribute__((aligned (sizeof(struct poll_list)))); > > This would require much more alignment than really necessary. Probably you meant > s/sizeof/alignof/. But Jes' patch is fine I think. I read your this patch now, so, I agree. Sorry for noise. -- OGAWA Hirofumi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/