Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp4188730ybt; Sun, 5 Jul 2020 20:47:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyATGzT4+kuKgcdZvDZf5HH1oVTx/TY6voFtJtB8BYvolzuKewD1d0F+Ll2FjB6jm813oqI X-Received: by 2002:aa7:d2c9:: with SMTP id k9mr44510983edr.98.1594007234612; Sun, 05 Jul 2020 20:47:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594007234; cv=none; d=google.com; s=arc-20160816; b=jN5QTJhXgZSMWJWEUxuzZLi0keIgzzAMRpeProLnF5lPL/55+T3MK/f3Fzypyhwnsc VJTLT4YFhp39Rfskvsil5HA5hffCoFEUZZLMyKl6RSbZ6n3H3UBWZ1lDKVsL+VJ5fKb9 LS8dU4zw9CklpOb1IEcooDsn59SFrStpnZfSWBcUglCzhkBOBmB4OQTcAkXbC4arJ0sJ EDxVOTa5M4JJBbObqlVDfnLaXOiGfAUMPbL5o8FYNJhLfwDTDgrFOP/eJlNxzc+RRIwt 1TW+Ij5Whd4/YxUaBeAIOc7eSLw8g6pYwrVwmGWDjZnKZv9pyBXQVpPkMtd9pNeDsqDP 335w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=41gou6XD+LYABVN+6OIMJTY7Kf5c7ZnU+/RpfSpPyxw=; b=OzafGZtVPpHrpRxday19/EUs13OHF/szKtifO0s2eEQgcCruvg9/6MOV0y/VN5IMEg 11+RLE4UwgveZE/cs63y7XW7z11RoCdAv5+X67cTMubOpp2rLbUR9gHsaOX6N9JDMlwE LW/zEzlqU21igi4TamlLPljdbHAUi7lb8yU7w5mdevCM0sdHg5ngyKj8hd/Zx8eH0/qU HdeL5xX94rlH8k0X2r8S20j6kgPdVK1zJ9sFbLFCbmpC0Mq1jpoDqGTWoTn2+LAyddda Moc8N7mLMibr89SD9mk4G4Nn9uSWhWRSJqQv+QH5R6+NoQaWawzzieZkmQOgJfULrqPQ 8ysA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dh1si12592319edb.54.2020.07.05.20.46.38; Sun, 05 Jul 2020 20:47:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728728AbgGFDqX (ORCPT + 99 others); Sun, 5 Jul 2020 23:46:23 -0400 Received: from mail1.windriver.com ([147.11.146.13]:60898 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728634AbgGFDqX (ORCPT ); Sun, 5 Jul 2020 23:46:23 -0400 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.2) with ESMTPS id 0663kA2F020619 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sun, 5 Jul 2020 20:46:10 -0700 (PDT) Received: from pek-lpg-core1-vm1.wrs.com (128.224.156.106) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.487.0; Sun, 5 Jul 2020 20:45:54 -0700 From: To: CC: , , , Subject: [PATCH] usb: gadget: function: fix missing spinlock in f_uac1_legacy Date: Sun, 5 Jul 2020 09:59:41 +0800 Message-ID: <20200705015941.40485-1-qiang.zhang@windriver.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhang Qiang Signed-off-by: Zhang Qiang --- drivers/usb/gadget/function/f_uac1_legacy.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/function/f_uac1_legacy.c b/drivers/usb/gadget/function/f_uac1_legacy.c index 349deae7cabd..e2d7f69128a0 100644 --- a/drivers/usb/gadget/function/f_uac1_legacy.c +++ b/drivers/usb/gadget/function/f_uac1_legacy.c @@ -336,7 +336,9 @@ static int f_audio_out_ep_complete(struct usb_ep *ep, struct usb_request *req) /* Copy buffer is full, add it to the play_queue */ if (audio_buf_size - copy_buf->actual < req->actual) { + spin_lock_irq(&audio->lock); list_add_tail(©_buf->list, &audio->play_queue); + spin_unlock_irq(&audio->lock); schedule_work(&audio->playback_work); copy_buf = f_audio_buffer_alloc(audio_buf_size); if (IS_ERR(copy_buf)) -- 2.24.1