Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CGME20200627125605epcas1p175ba4ecfbdea3426cc7b0a8fc1750cd0@epcas1p1.samsung.com>
 <20200627125509.142393-1-qkrwngud825@gmail.com> <003801d6502f$f40101c0$dc030540$@samsung.com>
In-Reply-To: <003801d6502f$f40101c0$dc030540$@samsung.com>
From:   Ju Hyung Park <qkrwngud825@gmail.com>
Date:   Mon, 6 Jul 2020 17:22:40 +0900
Message-ID: <CAD14+f0QUgXbDY8vK4HHKcWAh90Jp8DCMb-SRoFmmGrZ3cBhdw@mail.gmail.com>
Subject: Re: [PATCH] exfat: implement "quiet" option for setattr
To:     Namjae Jeon <namjae.jeon@samsung.com>
Cc:     Sungjong Seo <sj1557.seo@samsung.com>,
        open list <linux-kernel@vger.kernel.org>,
        linux-fsdevel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Namjae.

Looks like I ported this incorrectly from the previous sdFAT base.

I'll fix, test again and send v2.

Thanks.

On Thu, Jul 2, 2020 at 2:16 PM Namjae Jeon <namjae.jeon@samsung.com> wrote:
>
> >
> >       if (((attr->ia_valid & ATTR_UID) &&
> >            !uid_eq(attr->ia_uid, sbi->options.fs_uid)) || @@ -322,6 +325,12 @@ int
> > exfat_setattr(struct dentry *dentry, struct iattr *attr)
> >               goto out;
> You should remove goto statement and curly braces here to reach if error condition.
> >       }
> >
> > +     if (error) {
> > +             if (sbi->options.quiet)
> > +                     error = 0;
> > +             goto out;
> > +     }
>