Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1592892828-1934-1-git-send-email-iamjoonsoo.kim@lge.com>
 <1592892828-1934-9-git-send-email-iamjoonsoo.kim@lge.com> <fe0df827-e9d0-ec92-f4e1-99cfc6a6b9e9@suse.cz>
In-Reply-To: <fe0df827-e9d0-ec92-f4e1-99cfc6a6b9e9@suse.cz>
From:   Joonsoo Kim <js1304@gmail.com>
Date:   Mon, 6 Jul 2020 17:44:16 +0900
Message-ID: <CAAmzW4PZfyXTFo6FVGfx3f8Ys1qpp4TUet05i=tpM7MvfyVXow@mail.gmail.com>
Subject: Re: [PATCH v3 8/8] mm/page_alloc: remove a wrapper for alloc_migration_target()
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-team@lge.com,
        Christoph Hellwig <hch@infradead.org>,
        Roman Gushchin <guro@fb.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        Michal Hocko <mhocko@suse.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2020=EB=85=84 7=EC=9B=94 4=EC=9D=BC (=ED=86=A0) =EC=98=A4=EC=A0=84 1:18, Vl=
astimil Babka <vbabka@suse.cz>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> On 6/23/20 8:13 AM, js1304@gmail.com wrote:
> > From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> >
> > There is a well-defined standard migration target callback.
> > Use it directly.
> >
> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>
> But you could move this to patch 5/8 to reduce churn. And do the same wit=
h

Yes, I now realize that it is possible to make this change earlier.
However, reordering
the patches would cause additional change so I will not change the
order in the next
version. Result would be the same. :)

> mm/memory-failure.c new_page() there really, to drop the simple wrappers.=
 Only

Okay. As you suggested below, with NUMA_NO_NODE handling, we can remove
the more wrappers. I will do it.

> new_node_page() is complex enough.
> Hm wait, new_node_page() is only called by do_migrate_range() which is on=
ly
> called by __offline_pages() with explicit test that all pages are from a =
single
> zone, so the nmask could also be setup just once and not per each page, m=
aking
> it possible to remove the wrapper.

I have tried this suggestion and found that code is not simpler than before=
.
However, there would be minor performance benefit so I will include
this change, too.

> But for new_page() you would have to define that mtc->nid =3D=3D NUMA_NO_=
NODE means
> alloc_migrate_target() does page_to_nid(page) by itself.

Yes, I will use this suggestion.

Thanks.