Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 5fIPGTuNoMlgLhmj2gy+iLR4+kFqZXfdzLV0+qPfwp4ic3QTv2P5bnph/qnBnA4RORNn+OfNq4
 gXm4p4SVaR9lJMLMXwtHzT1ssWQy9HdFYaPaKmapMBLSiZU+wZytxf7Z+fVlAxzL8xdp0gNSo4
 wweDeS0U/97kjCRKun+bkwilFNNbwXkX+UcA1b4/J7F051jJ0xRckbriOuILGgogzRyFkU6suw
 TWWEmbRItjDbeXYBZkOcxSXOR6ITjYoWr32qspdqz6g1hDCBztfApY3Vp3U14tIdXslVxdm2W5
 HjA=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <huobean@gmail.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 1/2] scsi: ufs: differentiate dev_cmd trace message
Thread-Topic: [PATCH v1 1/2] scsi: ufs: differentiate dev_cmd trace message
Thread-Index: AQHWU3aK/GC0GWUMjkikzdUPEKmA9aj6RxFQ
Date:   Mon, 6 Jul 2020 09:24:49 +0000
Message-ID: <SN6PR04MB46404BDEAA0C802DB2592C34FC690@SN6PR04MB4640.namprd04.prod.outlook.com>
References: <20200706091905.12885-1-huobean@gmail.com>
 <20200706091905.12885-2-huobean@gmail.com>
In-Reply-To: <20200706091905.12885-2-huobean@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6396c5c0-7a4f-4206-799f-08d8218e6eb7
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2020 09:24:49.8316
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kuBJzKfyuTObgdj8lBwWDuDkg4eCoOqRAvZn9OqX7zLlIRSQiEm5LDh6EAVB5QsWrRq+ckFJLckIwyqGEVfccA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4350
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
>=20
> From: Bean Huo <beanhuo@micron.com>
>=20
> fshcd_exec_dev_cmd() can send query request and NOP request, and it is
Typo ?

> confusing that ufshcd_add_query_upiu_trace() prints us the "query_send"
> string in the trace log. Change it and add NOP key message in the trace
> print according to the dev_cmd type.
>=20
> Signed-off-by: Bean Huo <beanhuo@micron.com>
Our parsers already looking for those strings.
You can add stuff, but do not change anything that user-space already expec=
ts.

Thanks,
Avri


> ---
>  drivers/scsi/ufs/ufshcd.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 59358bb75014..173deee37e26 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -2727,7 +2727,9 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba
> *hba,
>=20
>         hba->dev_cmd.complete =3D &wait;
>=20
> -       ufshcd_add_query_upiu_trace(hba, tag, "query_send");
> +       ufshcd_add_query_upiu_trace(hba, tag,
> +                                   cmd_type =3D=3D DEV_CMD_TYPE_QUERY ?
> +                                   "send QUERY" : "send NOP");
>         /* Make sure descriptors are ready before ringing the doorbell */
>         wmb();
>         spin_lock_irqsave(hba->host->host_lock, flags);
> @@ -2738,7 +2740,7 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba
> *hba,
>         err =3D ufshcd_wait_for_dev_cmd(hba, lrbp, timeout);
>=20
>         ufshcd_add_query_upiu_trace(hba, tag,
> -                       err ? "query_complete_err" : "query_complete");
> +                       err ? "dev_cmd err" : "dev_cmd complete");
>=20
>  out_put_tag:
>         blk_put_request(req);
> --
> 2.17.1