Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp39637ybt;
        Mon, 6 Jul 2020 03:34:08 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzqdXgsHrSQMgLfE80zxjaz0+9XDTPZiLm0XUqGIBg+8loKuiMjKhMgnZ1pMH5ExobSaLoZ
X-Received: by 2002:a17:906:cc13:: with SMTP id ml19mr42115137ejb.288.1594031648402;
        Mon, 06 Jul 2020 03:34:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1594031648; cv=none;
        d=google.com; s=arc-20160816;
        b=OKQ05tZWnV1MHOkZU4qT/15sZCZ/19tj8va/WGrNqU8xbC0dLqFDLEjuhb1+aW/esx
         vju9ci52mrruCJlIe8QeiVu85kAEIuwRHgY6St7hqa6FIcJBI/B6sJRhXAB6zstDaSMQ
         7APjRa3TqeSUvOjUIRg8M5+SqB+snKCDnC9OZpMiqfZqkNJAw8y5KdOU7PQhary4LkOr
         3biFioelnscwDbsGEHXHEPWVCjLkOrFS+eQnekqJlrvlp3v6jxxUSJkzGIRUjWpRtBY9
         FvaXt1p6bQhonJDc2kFv4VLBVLZfyM36eeCi4oC+xQ7IqQi0H1mGSm/lgJTxnkShxjeD
         o2XQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=HrT1n41crAuqDHCxJQMplB8P97ZnfywvPr0n7BdcJJc=;
        b=u0j1kC3SBF/uj/TUKaWjiDDzudkDBDxT3DCuWmO9ztaa+vaM9GVh0UrIrndTYdUl9s
         GkFQja+lvcY0TCM3JJvf4Q8zlmzKN813mkMCre17f0Qdz39ydPlUwd4KA94tAXtlIsjv
         8DsqJ4XgtlLlXzdbP6iF5FpdIyT9Mq+e/k0f8xTa/wvQWToiBKqXWlYQT20d6oHcfLGE
         BLLLi/snjO+GShft+gsRyVMQ7VpTqjvgrGEdqI7navPJHRCswi+oxl5zWZc0EQJAH7HZ
         SEfNqDVEEJdUaf1jay7Awuj7s04pIYjW4aJ/yGM1XAU3ZYUt5u8Viqqrcktg9yBSpJ8M
         Xo4g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=Lut7e6l0;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id sd17si8026516ejb.423.2020.07.06.03.33.44;
        Mon, 06 Jul 2020 03:34:08 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=Lut7e6l0;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728895AbgGFKbd (ORCPT <rfc822;zoe.song.ucas@gmail.com>
        + 99 others); Mon, 6 Jul 2020 06:31:33 -0400
Received: from mail.kernel.org ([198.145.29.99]:50982 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728733AbgGFKbd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Jul 2020 06:31:33 -0400
Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 78E992073E;
        Mon,  6 Jul 2020 10:31:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1594031493;
        bh=PKJqXwmnBUa/sptDECePTi5+E2rgrpZGpUUkwLdHA+E=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=Lut7e6l0dkPiNYIDGARuhUsomrpajCRtmTrFxnfS+5vl+arDqhJr9Q+2vfeIfSkXS
         JkWpAtJq5kjg62GddK3XPOhr6U+/6ecCtLqwUGAuBOmKGPRJbOhOQXhXj3828/mfCU
         ZaJ2F2Z34FjPEG4NodzVJobhmPZnd14ruq/d2GLE=
Date:   Mon, 6 Jul 2020 12:31:30 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     qiang.zhang@windriver.com
Cc:     balbi@kernel.org, colin.king@canonical.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: gadget: function: fix missing spinlock in
 f_uac1_legacy
Message-ID: <20200706103130.GB10624@kroah.com>
References: <20200705061616.833-1-qiang.zhang@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200705061616.833-1-qiang.zhang@windriver.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jul 05, 2020 at 02:16:16PM +0800, qiang.zhang@windriver.com wrote:
> From: Zhang Qiang <qiang.zhang@windriver.com>
> 
> Add a missing spinlock protection to the add operation of the "audio->play_queue"
> in "f_audio_out_ep_complete" function.

That says _what_ you did, but not _why_ you did that.  Why is a lock
needed here?  What does this protect?

What kernel commit does this "fix"?  Put that in the "Fixes:" line, and
probably you need a "cc: stable" in that area too, right?

thanks,

greg k-h