Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: wIJhBVfJYbOXelU5nPj89WSh/xhvR86Dvg1D5r1IiYHBH2ZmUWU+YQyHEb0r7PD8QPj3zy7ruZ
 ZSBwymnCYficWCaCkLyc4tX543fHM1LasHZUC+GXxXFvOERbXTibFZVyOB95JixfPosA+YT+OR
 hH8yYY/R9ukADSZjpyhkndoHExwhUa3yY20j+Yg9csCuLit1dx2Fk6lsXXZh2Me01b+G6ioewG
 u2w9F6U6zVDquM6Fl30UCe7ByYp5mf3CzJUs3z7GoG+rjrwJQHvFJ7r/i+AklFHEdkusclp45e
 xZo=
From:   <Peter.Huewe@infineon.com>
To:     <jarkko.sakkinen@linux.intel.com>,
        <linux-integrity@vger.kernel.org>
CC:     <kjhall@us.ibm.com>, <ferry.toth@elsinga.info>,
        <peterhuewe@gmx.de>, <jgg@ziepe.ca>, <arnd@arndb.de>,
        <gregkh@linuxfoundation.org>, <akpm@osdl.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] tpm_tis: Remove the HID IFX0102
Thread-Topic: [PATCH v2] tpm_tis: Remove the HID IFX0102
Thread-Index: AQHWSpi7zu+k2ZgGwES2mspmWAztdKj6fvXg
Date:   Mon, 6 Jul 2020 11:46:46 +0000
Message-ID: <e9caad58aba44bb3abeac8569a6bd8ed@infineon.com>
References: <20200625023111.270458-1-jarkko.sakkinen@linux.intel.com>
In-Reply-To: <20200625023111.270458-1-jarkko.sakkinen@linux.intel.com>
Accept-Language: de-DE, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,
NACK

> % git --no-pager grep IFX0102 drivers/char/tpm
> drivers/char/tpm/tpm_infineon.c:	{"IFX0102", 0},
> drivers/char/tpm/tpm_tis.c:	{"IFX0102", 0},		/* Infineon */
> Obviously IFX0102 was added to the HID table for the TCG TIS driver by mi=
stake.

The HID IFX0102 was NOT added by mistake.
Let me explain the history a bit:

Old SLB 9635 / 9630 TPMs had two ways to interface them
- proprietary 'io' mapped protocol (tpm_infineon)
- tis protocol  (tpm_tis)

Both match the same HID.
However with the emerging of the tis protocol, the io protocol eventually w=
ent away for newer products.
So all TPM1.2 by IFX match the HID0102 and the TCG generic ones PNP0C31

So basically you break TPM1.2 support for all (newer) Infineon chips if the=
 platform vendor used the IFX0102 HID as they would speak via tpm_infineon =
driver.
The bug must be something different, especially as it only seems to happen =
after suspend resume.


Thanks,
Peter