Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200705133038.161547-1-mans0n@gorani.run> <CAMpxmJUxGq3_R7BRGv68ApeNC+g9PDm_kBd0r=8TjFSyTNxFWg@mail.gmail.com>
In-Reply-To: <CAMpxmJUxGq3_R7BRGv68ApeNC+g9PDm_kBd0r=8TjFSyTNxFWg@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 6 Jul 2020 15:00:05 +0300
Message-ID: <CAHp75Vf4440V5Oh1SA5tjVgss134qGkx591ANDY3aQ+oecEzmw@mail.gmail.com>
Subject: Re: [PATCH v5 1/2] gpio: add GPO driver for PCA9570
To:     Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc:     Sungbo Eo <mans0n@gorani.run>,
        Linus Walleij <linus.walleij@linaro.org>,
        Michael Walle <michael@walle.cc>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 6, 2020 at 2:21 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:>
> On Sun, Jul 5, 2020 at 3:31 PM Sungbo Eo <mans0n@gorani.run> wrote:
> >
> > NXP PCA9570 is a 4-bit I2C GPO expander without interrupt functionality.
> > Its ports are controlled only by a data byte without register address.
> >

> > Datasheet: https://www.nxp.com/docs/en/data-sheet/PCA9570.pdf
> >

No blank line here.

> > Signed-off-by: Sungbo Eo <mans0n@gorani.run>

> This driver looks nice now but why did you remove the mutex in v3? I
> think when Andy commented on that, he meant not understanding why the
> error check is protected, not the i2c operations.

Right.

> Are you sure you don't need this lock?

It's a good point!

-- 
With Best Regards,
Andy Shevchenko