Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <2f76f069f2078b3d51533f772f1094dcc03685a3.camel@gmail.com>
Subject: Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = "
 log messages
From:   Filipe =?ISO-8859-1?Q?La=EDns?= <filipe.lains@gmail.com>
To:     "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     Harry Cutts <hcutts@chromium.org>,
        Peter Hutterer <peter.hutterer@who-t.net>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <7d2c980f071487cecfd1534adb7561b33d922af3.1593970340.git.mail@maciej.szmigiero.name>
References: <7d2c980f071487cecfd1534adb7561b33d922af3.1593970340.git.mail@maciej.szmigiero.name>
Organization: Archlinux
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-/JbVFOtHolAxXpvgH3yU"
Date:   Mon, 06 Jul 2020 13:38:04 +0100
MIME-Version: 1.0
User-Agent: Evolution 3.36.3 
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-/JbVFOtHolAxXpvgH3yU
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 2020-07-05 at 19:34 +0200, Maciej S. Szmigiero wrote:
> These messages appear each time the mouse wakes from sleep, in my
> case
> (Logitech M705), every minute or so.
> Let's downgrade them to the "debug" level so they don't fill the
> kernel log
> by default.
>=20
> While we are at it, let's make clear that this is a wheel multiplier
> (and
> not, for example, XY movement multiplier).
>=20
> Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling
> on Logitech mice")
> Cc: stable@vger.kernel.org
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> ---
> Sending again since the previous message bounced for most recipients.
>=20
>  drivers/hid/hid-logitech-hidpp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index 1e1cf8eae649..b8b53dc95e86 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct
> hidpp_device *hidpp)
>  		multiplier =3D 1;
> =20
>  	hidpp->vertical_wheel_counter.wheel_multiplier =3D multiplier;
> -	hid_info(hidpp->hid_dev, "multiplier =3D %d\n", multiplier);
> +	hid_dbg(hidpp->hid_dev, "wheel multiplier =3D %d\n", multiplier);
>  	return 0;
>  }
> =20

I have seen this being useful in some cases, however I do not have a
strong opinion on it. Peter would know better.

Cheers,
Filipe La=C3=ADns

--=-/JbVFOtHolAxXpvgH3yU
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0jW0leqs33gyftiw+JPGdIFqqV0FAl8DGyYACgkQ+JPGdIFq
qV2X+BAAodOXRsLeK4VZh5PBrDPvqTjUWn7Y1TEFkSZBxAQVzyL1Uv1TvtOjUPIn
Q65fmafPxfwW+BNNiTeMhqVCUzPNLGjH65aHlVB5ZWYxiTO1k4OKwcCMgpcM6C69
vdJ2lJjRjWpsmq6gw4QxlmuiaEm1BcAx6IbbIBBXFz2LoypDjT5D6enYLNdLMAdO
/B+BtUJVhZJFeUV3gNqiUcay6YSKzkHycf+ZgpxFMOJRwnAfPKlVnqKXawzteJAX
2YVNmyhc+qrNEpAw/t5KrBvoZZJr0XAF/izj021XtJjPPaDde8R1AtmJ1V2Ru6Sv
Cq8f+AcuBCvykmS3RdWvOAq0BMyI8/hrrlc8iFsaja8GFZqfov+Qk+PnfSk+NAub
/vbvurzLqV4Di68+8Zb5dvsYmQBIisf+gq7kvuUBd6aKTEdar84wOXCXMjjcdiDp
zfz20Dpw+f62a5ORVkIJ305PwVugrWK8YR8HikdIdtSoSKkJMRaXn9Cyz1vi1W6D
vGsuG1q0IjDxdKVkpW863RGC/AXMrQkOB24Mr5H499n8QWgnjqaCSYimoGGbzihU
vy7YjOr5Ma5Olsq0kLXp3KY8RVcnXpSAcaoqAd0xWIKBwZPw/4cKDo7lD2uCjgKa
B31lJwUKysIjK1AgQzNY7fKHOvmqxZGtJpSIg1FKg+sDav1j2us=
=C+AW
-----END PGP SIGNATURE-----

--=-/JbVFOtHolAxXpvgH3yU--