Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932107AbWCaTd6 (ORCPT ); Fri, 31 Mar 2006 14:33:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932109AbWCaTd6 (ORCPT ); Fri, 31 Mar 2006 14:33:58 -0500 Received: from pasmtp.tele.dk ([193.162.159.95]:18184 "EHLO pasmtp.tele.dk") by vger.kernel.org with ESMTP id S932107AbWCaTd5 (ORCPT ); Fri, 31 Mar 2006 14:33:57 -0500 Date: Fri, 31 Mar 2006 21:33:38 +0200 From: Sam Ravnborg To: Adrian Bunk Cc: Dave Jones , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: smp_locks reference_discarded errors Message-ID: <20060331193338.GA10664@mars.ravnborg.org> References: <20060325033948.GA15564@redhat.com> <20060325235035.5fcb902f.akpm@osdl.org> <20060326154042.GB13684@redhat.com> <20060326161055.GA4584@mars.ravnborg.org> <20060331190851.GB22677@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060331190851.GB22677@stusta.de> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1258 Lines: 28 On Fri, Mar 31, 2006 at 09:08:51PM +0200, Adrian Bunk wrote: > On Sun, Mar 26, 2006 at 06:10:55PM +0200, Sam Ravnborg wrote: > > On Sun, Mar 26, 2006 at 10:40:42AM -0500, Dave Jones wrote: > > > > > > came out of a 'make buildcheck' a day or two ago (the following day, > > > Sam nuked reference_discarded.pl in favour of it being done > > > magically somewhere else (I've not looked into how its done now). > > The check is part of modpost now. modpost is only used when building > > modules but that holds true for most builds anyway therefore I did not > > move it to a separate executable. > >... > > This doesn't sound good. > > This means that we have no longer any tool that warns us about e.g. > references from non-__exit code to __exit code [1]? > [1] __exit, not __{dev,cpu,mem}exit It does warn for this also. The test I have carried out has mostly been on allmodconfig builds though. I assume you are worried for the case when a module is built-in and the __exit section is discarded - or? Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/