Date: Fri, 31 Mar 2006 21:40:13 +0200
From: Jens Axboe <axboe@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: tridge@samba.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] splice support #2
Message-ID: <20060331194012.GE14022@suse.de>
References: <17452.50912.404106.256236@samba.org> <20060331095711.GK14022@suse.de> <Pine.LNX.4.64.0603311110540.27203@g5.osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.0603311110540.27203@g5.osdl.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 926
Lines: 25

On Fri, Mar 31 2006, Linus Torvalds wrote:
> 
> 
> On Fri, 31 Mar 2006, Jens Axboe wrote:
> > > 
> > >   ssize_t psplice(int fdin, int fdout, size_t len, off_t ofs, unsigned flags);
> > 
> > I definitely see some valid reasons for adding a file offset instead of
> > using ->f_pos, I'll leave that decision up to Linus though. Linus?
> 
> I think a file offset is fine, the one thing holding me back was just the 
> interface. One file offset per fd? Or just have the rule that the file 
> offset is for the "non-pipe" device?

Intuitively, I'd expect the offset to be tied to the non-pipe if I were
to eg see this for the first time. So my vote would go for that.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/