Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp168682ybt; Mon, 6 Jul 2020 06:41:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLCFwYBY7uRytaCrt+3b9BRNhXNwRrAD17U587ljgTNWqwEhHJWO4/KlRPJFuGPiO/v8Vh X-Received: by 2002:a17:906:35ce:: with SMTP id p14mr42763915ejb.514.1594042905709; Mon, 06 Jul 2020 06:41:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594042905; cv=none; d=google.com; s=arc-20160816; b=hZb+r0UGPsnATPBOgMJPOGRH3KSoGPR6ZMCqf7xj+CDENW73PKZNISJ2l+WkUUfaKb yE+mcFjIriews+IVSu8lUOoMKkMG0h9Fx8rNuAN1mAlZx54HKzLk41A2ZhvfDO8xLmz9 cV2ds3FtRkCCQhh71WtCjSWngI/ETGN8YUAyVumq9XhbvIu9OsrsgYzEGqeI8U+y5VoQ cg4AUQUlE/pMqutSZtSAZQomJXU+jMfrctUyAHktKfvdNkglVXYshDfjoqxt8cO7n4Yx UcVAi1RPc2FByJF5CFf9RHNyoAFoUjeLwo5a8MzVdHs4Wtdpzf/O8oUrSIX3e7EmQJcS 3FqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=hD3fp2aNNDiWJbia8QoB243uBC6/+gQFK4B9r5zZ4Cs=; b=sPQ06mF6D9aDKg8PCJRh7alzTDwo8e0UgqnTo9CjJxmkm3DCPpJZ+EWEGiUnZlbxoP tZ1y/BXwwQM9iYBEAOcVFNlToMLJzwklySGaAj7UKUXc0785NvYxR+xivxO5x1pEA3K/ Bo0UF4AlxQCyq7dovU3Dm1mDmGhqeS9AgloUCeMzT1RIE7RsEiLffji9FMkQi0tBWGau N/clBR686DNkTMi1EDSxKlxkk5O5puX0v712kYhgFLBdd6PX3phekKD68w6tcFTVt6ww tDEdhh+HMEjdGBAGBRR4HRk38MJOlbLrsHiE0sFslusNEGm3cyTDIOZEiA5MlXcrpgs0 uDYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f21si15499607ejl.362.2020.07.06.06.41.22; Mon, 06 Jul 2020 06:41:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729165AbgGFNjU (ORCPT + 99 others); Mon, 6 Jul 2020 09:39:20 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:52476 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729160AbgGFNjU (ORCPT ); Mon, 6 Jul 2020 09:39:20 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 94431C96B0A586C9ED94; Mon, 6 Jul 2020 21:39:16 +0800 (CST) Received: from kernelci-master.huawei.com (10.175.101.6) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Mon, 6 Jul 2020 21:39:09 +0800 From: Wei Yongjun To: Hulk Robot , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Sebastian Andrzej Siewior , "Paul E. McKenney" , Peter Xu CC: Wei Yongjun , Subject: [PATCH -next] smp: Fix unused-but-set-variable warning Date: Mon, 6 Jul 2020 21:49:19 +0800 Message-ID: <20200706134919.80407-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.175.101.6] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gcc report build warning as follows: kernel/smp.c:126:15: warning: variable 'csd_type' set but not used [-Wunused-but-set-variable] 126 | unsigned int csd_type; | ^~~~~~~~ 'csd_type' is only used when CONFIG_64BIT defined, so move them under '#ifdef'. Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/smp.c b/kernel/smp.c index 6ec6c9578225..0130bdcf6d26 100644 --- a/kernel/smp.c +++ b/kernel/smp.c @@ -123,10 +123,10 @@ static void csd_lock_record(call_single_data_t *csd) static __always_inline int csd_lock_wait_getcpu(call_single_data_t *csd) { +#ifdef CONFIG_64BIT unsigned int csd_type; csd_type = CSD_TYPE(csd); -#ifdef CONFIG_64BIT if (csd_type == CSD_TYPE_ASYNC || csd_type == CSD_TYPE_SYNC) return csd->dst; // Other CSD_TYPE_ values might not have ->dst. #endif