Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: N373rT1nSZVN0L7Ho6D+HHXlYdhs++lhKiA8wz+6md6BEeVC2Gkl/mpBQNV4vW062Ix+wr42tQ
 oESuk94vsDVw==
Subject: Re: [PATCH v4 14/18] nitro_enclaves: Add Kconfig for the Nitro
 Enclaves driver
To:     Alexander Graf <graf@amazon.de>, <linux-kernel@vger.kernel.org>
CC:     Anthony Liguori <aliguori@amazon.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Colm MacCarthaigh <colmmacc@amazon.com>,
        "Bjoern Doebel" <doebel@amazon.de>,
        David Woodhouse <dwmw@amazon.co.uk>,
        "Frank van der Linden" <fllinden@amazon.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Martin Pohlack <mpohlack@amazon.de>,
        Matt Wilson <msw@amazon.com>,
        "Paolo Bonzini" <pbonzini@redhat.com>,
        Balbir Singh <sblbir@amazon.com>,
        "Stefano Garzarella" <sgarzare@redhat.com>,
        Stefan Hajnoczi <stefanha@redhat.com>,
        Stewart Smith <trawets@amazon.com>,
        Uwe Dannowski <uwed@amazon.de>, <kvm@vger.kernel.org>,
        <ne-devel-upstream@amazon.com>
References: <20200622200329.52996-1-andraprs@amazon.com>
 <20200622200329.52996-15-andraprs@amazon.com>
 <0576a41d-f915-24b3-e6f9-0bc3616fd75b@amazon.de>
From:   "Paraschiv, Andra-Irina" <andraprs@amazon.com>
Message-ID: <3da5e023-47d0-09c1-89b8-94a80fbeba85@amazon.com>
Date:   Mon, 6 Jul 2020 16:50:23 +0300
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <0576a41d-f915-24b3-e6f9-0bc3616fd75b@amazon.de>
Content-Language: en-US
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 06/07/2020 14:28, Alexander Graf wrote:
>
>
> On 22.06.20 22:03, Andra Paraschiv wrote:
>> Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
>> ---
>> Changelog
>>
>> v3 -> v4
>>
>> * Add PCI and SMP dependencies.
>>
>> v2 -> v3
>>
>> * Remove the GPL additional wording as SPDX-License-Identifier is
>> =A0=A0 already in place.
>>
>> v1 -> v2
>>
>> * Update path to Kconfig to match the drivers/virt/nitro_enclaves
>> =A0=A0 directory.
>> * Update help in Kconfig.
>> ---
>> =A0 drivers/virt/Kconfig=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 |=
=A0 2 ++
>> =A0 drivers/virt/nitro_enclaves/Kconfig | 16 ++++++++++++++++
>> =A0 2 files changed, 18 insertions(+)
>> =A0 create mode 100644 drivers/virt/nitro_enclaves/Kconfig
>>
>> diff --git a/drivers/virt/Kconfig b/drivers/virt/Kconfig
>> index cbc1f25c79ab..80c5f9c16ec1 100644
>> --- a/drivers/virt/Kconfig
>> +++ b/drivers/virt/Kconfig
>> @@ -32,4 +32,6 @@ config FSL_HV_MANAGER
>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 partition shuts down.
>> =A0 =A0 source "drivers/virt/vboxguest/Kconfig"
>> +
>> +source "drivers/virt/nitro_enclaves/Kconfig"
>> =A0 endif
>> diff --git a/drivers/virt/nitro_enclaves/Kconfig =

>> b/drivers/virt/nitro_enclaves/Kconfig
>> new file mode 100644
>> index 000000000000..69e41aa2222d
>> --- /dev/null
>> +++ b/drivers/virt/nitro_enclaves/Kconfig
>> @@ -0,0 +1,16 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +#
>> +# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights =

>> Reserved.
>> +
>> +# Amazon Nitro Enclaves (NE) support.
>> +# Nitro is a hypervisor that has been developed by Amazon.
>> +
>> +config NITRO_ENCLAVES
>> +=A0=A0=A0 tristate "Nitro Enclaves Support"
>> +=A0=A0=A0 depends on HOTPLUG_CPU && PCI && SMP
>
> Let's also depend on ARM64 || X86, so that we don't burden all of the =

> other archs that are not available in EC2 today with an additional =

> config option to think about.

Included the arch specs.

Thanks,
Andra


Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar=
 Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in R=
omania. Registration number J22/2621/2005.