Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp182095ybt; Mon, 6 Jul 2020 06:58:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBL9N8RdLJ6yIIGP00rrmPBFYoqnexjfrMBf3Z7ufUqH+Be9Zq9prPw+1Cc9P0RserrFap X-Received: by 2002:a17:906:4e87:: with SMTP id v7mr31054173eju.242.1594043929049; Mon, 06 Jul 2020 06:58:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594043929; cv=none; d=google.com; s=arc-20160816; b=it3BqNr7IM6d1NG0huSbJ5T/ac0XS9Bi4JDuSQ6hgV9eGtoNSVijU/ZWeP4FhW+lTH tolnePnzABOUQzXLqSUxD2I7iL/3pDte9DQ6fuooDepJjY7VGZDerhh9yoPo/D+UvMIs SoPmzkQA/jvyC/y+fjvZSoC0BYXLyG+SOiM0VqlUCjIf/HixKPmlMuFiGMgiLoHnV8ab m7+L8qNKrmDkxWYsC4oQnRk6KzdpnhjTTfPDSnBPVYCm9F04YYcXt42FNth7Eg6CDeZm 2bE7QYv9keoHjfYKUves5Sks9M7ysvhilkSGBhcVaxhLyp51ww33XEWAnQtdHPOqOS7e J+hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=trTp6svXZMdTKhI33PGeyCRhQ/KIgdX/k27yJzcwCMc=; b=hbR7Y5sk9tgZlKRHhaZPLpkANSm5cFIZNHdy1RcrU4ry96l2yeRFXtntyiJFG5fuPk CDb5tx8sZdDbOVKQ1NRSnBbrdAvm0ypOCxVgaQZYHFTFRqoXiOXIqCAc5xTgFrUjGFyJ CU3u66YMfzVKSqbVLjQJNM0m/CLhrINQxSg0r+9Jh5q+ZqJB/ODIRBpfA6hK9pIzTPZ5 IL9/A6Abwy9Ucx8mp8j/5L23cAzeA38SJM90teWiofliqbDc+ro4g55Kdyn6jDNDrEKG AvzB7aNGbkjwsTpYk2en54LZGcNzVm8Zsl3JVR+HZTyvMbiK9ar6zEJ5Bzl5KGy9fV4N aSIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y19si13311842ejm.324.2020.07.06.06.58.26; Mon, 06 Jul 2020 06:58:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729177AbgGFN5U (ORCPT + 99 others); Mon, 6 Jul 2020 09:57:20 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49034 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728940AbgGFN5U (ORCPT ); Mon, 6 Jul 2020 09:57:20 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jsRcT-003rgn-D2; Mon, 06 Jul 2020 15:57:17 +0200 Date: Mon, 6 Jul 2020 15:57:17 +0200 From: Andrew Lunn To: Diana Craciun Cc: linux-kernel@vger.kernel.org, laurentiu.tudor@nxp.com, gregkh@linuxfoundation.org, stuyoder@gmail.com, leoyang.li@nxp.com, bharatb.linux@gmail.com, Diana Craciun , Bharat Bhushan , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 03/13] bus/fsl-mc: add support for 'driver_override' in the mc-bus Message-ID: <20200706135717.GB919533@lunn.ch> References: <20200706124243.10697-1-diana.craciun@nxp.com> <20200706124243.10697-4-diana.craciun@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200706124243.10697-4-diana.craciun@nxp.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Diana On Mon, Jul 06, 2020 at 03:42:33PM +0300, Diana Craciun wrote: > From: Bharat Bhushan > > This patch is required for vfio-fsl-mc meta driver to successfully bind > layerscape container devices for device passthrough. This patch adds > a mechanism to allow a layerscape device to specify a driver rather than > a layerscape driver provide a device match. > > Example to allow a device (dprc.1) to specifically bind > with driver (vfio-fsl-mc):- > - echo vfio-fsl-mc > /sys/bus/fsl-mc/devices/dprc.1/driver_override > - echo dprc.1 > /sys/bus/fsl-mc/drivers/fsl_mc_dprc/unbind > - echo dprc.1 > /sys/bus/fsl-mc/drivers/vfio-fsl-mc/bind Something i asked before, why is this buried in a driver, when it could be put in the driver core. This is not the only driver doing this, so it does make sense to share the code and bugs. Andrew