Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: embVS7qNPj8VpXRvnZcKMMbCIo3DNSOdX1mf8ziYLCu6OiuOSQ50IN/ILthTyii0oMIQsYnD0+
 eFEHMZm8PhUg==
IronPort-SDR: 95nYChopbbyIok5aSV5FwZ5pkzwn1q71KpL03gPyMNYEqiC/u36zyeasGBSXtiCcovTFMRLRUs
 OU0SasUX/hBQ==
Date:   Mon, 6 Jul 2020 17:00:51 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Peter.Huewe@infineon.com
Cc:     linux-integrity@vger.kernel.org, kjhall@us.ibm.com,
        ferry.toth@elsinga.info, peterhuewe@gmx.de, jgg@ziepe.ca,
        arnd@arndb.de, gregkh@linuxfoundation.org, akpm@osdl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tpm_tis: Remove the HID IFX0102
Message-ID: <20200706140051.GB3816@linux.intel.com>
References: <20200625023111.270458-1-jarkko.sakkinen@linux.intel.com>
 <e9caad58aba44bb3abeac8569a6bd8ed@infineon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e9caad58aba44bb3abeac8569a6bd8ed@infineon.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 06, 2020 at 11:46:46AM +0000, Peter.Huewe@infineon.com wrote:
> Hi,
> NACK
> 
> > % git --no-pager grep IFX0102 drivers/char/tpm
> > drivers/char/tpm/tpm_infineon.c:	{"IFX0102", 0},
> > drivers/char/tpm/tpm_tis.c:	{"IFX0102", 0},		/* Infineon */
> > Obviously IFX0102 was added to the HID table for the TCG TIS driver by mistake.
> 
> The HID IFX0102 was NOT added by mistake.
> Let me explain the history a bit:
> 
> Old SLB 9635 / 9630 TPMs had two ways to interface them
> - proprietary 'io' mapped protocol (tpm_infineon) - tis protocol  (tpm_tis)
> 
> Both match the same HID.
> However with the emerging of the tis protocol, the io protocol eventually went away for newer products.
> So all TPM1.2 by IFX match the HID0102 and the TCG generic ones PNP0C31
> 
> So basically you break TPM1.2 support for all (newer) Infineon chips if the platform vendor used the IFX0102 HID as they would speak via tpm_infineon driver.
> The bug must be something different, especially as it only seems to happen after suspend resume.

Peter,

Looking at dmesg:

1. tmp_infineon initializes cleanly
2. tpm_tis fails misserably with bunch error messages

I'm cool with reverting the patch though. Please send a revert patch and
explain this in the commit message because right now what you are saying
is completely undocumented.

Also, this tpm_infineon issue needs to be fixed properly after the
revert.

The bugzilla bug is unrelated to this issue but it causes extra harm
fixing any bugs and confusion among the users as the bug discussions
proves.

How do we get the quirks for tpm_tis and tpm_infineon so that they can
separate each other?

/Jarkko