Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp228090ybt; Mon, 6 Jul 2020 07:58:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBAjEo2lwupuxWihMMaNFQPGFe4I49iRkx+pBghwQY/ZakQYLbundoaVQJu44BQdtYzqBq X-Received: by 2002:a17:906:2a5b:: with SMTP id k27mr42239939eje.82.1594047538382; Mon, 06 Jul 2020 07:58:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594047538; cv=none; d=google.com; s=arc-20160816; b=JLIFC9nQnkAG+0oZVjKTu6lzCy7IJkN3fAymD5Duzjg0GXcMOyjF4vk4bphBIJQ/Cx hMnQmamPCKc0di843oNFih1yNOkcP05GCK9yp7/PggoyGCs6v0WQOmMfuDdlubGX8cFS Vtx0/7qmbVbhTjlBmHwgfQN/44qtDaVUhToZm/sW9P8zWGwlZjU2LcUrkheO9bYCnv4h wjKhoQr3/FCmDqTHzbwnFRlGV5sd9kKzLeSbp/QmFKZb3ID6KfixoCAk19YJttF7iT50 Vg+zXhGngJdBvh/YFWPoxbDJwRAc3QpKz43NOyDKFVd3FqeZvZ+YN8ZBxWpsb3tJrbeY 32eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=oMePpw4KJ8oLkHE5bIzXQgc7c5+2PVStDsI9W0wEkS0=; b=J6luX04bHt4thJXfJ1BSz0VSuPAy0ps/ea8c2dwLuNyXVFw68zg3NroabObIaRh4F2 6l2Cn9v/7zzwwzs/HR+L+LZq5L6I7KbxlcvdyFgOcEsIC26Nf2z2GhqkAZBNkY0RVd4n sU5ZhJStC4WoSLBmsg6TBBTnp2vDVIuNSR1TuyOkX8z0+7WYBZLruGFAl+cH0aQqN97d cyXIzmCgZdVEuIzyC58URjpsnlXDEdwOvyxr+MSPo228w9TEJgUDYNpxxml2aUKdghtc J39FJJsfuswlFEB+OFEF4bcOi0S+AqrcEuZx+ncJ3H5shqJPwVv0fMvqxvyFMhM1Oo6U RfIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rk8si13604612ejb.578.2020.07.06.07.58.34; Mon, 06 Jul 2020 07:58:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729353AbgGFO4V (ORCPT + 99 others); Mon, 6 Jul 2020 10:56:21 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:6839 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729229AbgGFO4V (ORCPT ); Mon, 6 Jul 2020 10:56:21 -0400 X-Greylist: delayed 547 seconds by postgrey-1.27 at vger.kernel.org; Mon, 06 Jul 2020 10:56:18 EDT Received: from spf.mail.chinamobile.com (unknown[172.16.121.1]) by rmmx-syy-dmz-app02-12002 (RichMail) with SMTP id 2ee25f033961a8e-4271c; Mon, 06 Jul 2020 22:46:57 +0800 (CST) X-RM-TRANSID: 2ee25f033961a8e-4271c X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.0.156.39]) by rmsmtp-syy-appsvr01-12001 (RichMail) with SMTP id 2ee15f03395dfa9-abca0; Mon, 06 Jul 2020 22:46:57 +0800 (CST) X-RM-TRANSID: 2ee15f03395dfa9-abca0 From: Tang Bin To: davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin , Zhang Shengju Subject: [PATCH] net/amd: Remove needless assignment and the extra brank lines Date: Mon, 6 Jul 2020 22:47:01 +0800 Message-Id: <20200706144701.7500-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The variable 'err = -ENODEV;' in au1000_probe() is duplicate, so remove redundant one. And remove the extra blank lines in the file au1000_eth.c Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin --- drivers/net/ethernet/amd/au1000_eth.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c index 089a4fbc6..7dd8f2104 100644 --- a/drivers/net/ethernet/amd/au1000_eth.c +++ b/drivers/net/ethernet/amd/au1000_eth.c @@ -243,7 +243,6 @@ MODULE_VERSION(DRV_VERSION); * ps: make sure the used irqs are configured properly in the board * specific irq-map */ - static void au1000_enable_mac(struct net_device *dev, int force_reset) { unsigned long flags; @@ -558,7 +557,6 @@ static int au1000_mii_probe(struct net_device *dev) return 0; } - /* * Buffer allocation/deallocation routines. The buffer descriptor returned * has the virtual and dma address of a buffer suitable for @@ -649,7 +647,6 @@ au1000_setup_hw_rings(struct au1000_private *aup, void __iomem *tx_base) /* * ethtool operations */ - static void au1000_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { @@ -682,7 +679,6 @@ static const struct ethtool_ops au1000_ethtool_ops = { .set_link_ksettings = phy_ethtool_set_link_ksettings, }; - /* * Initialize the interface. * @@ -1258,7 +1254,6 @@ static int au1000_probe(struct platform_device *pdev) aup->rx_db_inuse[i] = pDB; } - err = -ENODEV; for (i = 0; i < NUM_TX_DMA; i++) { pDB = au1000_GetFreeDB(aup); if (!pDB) -- 2.20.1.windows.1