Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200703123431.GG1320@kernel.org> <CAM9d7cgGcpnX+cSY0UvYjRkG9PF8X3Yyf_AOy+nGxbPjtjDvxw@mail.gmail.com>
 <20200706115452.GA2772@redhat.com>
In-Reply-To: <20200706115452.GA2772@redhat.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Tue, 7 Jul 2020 00:12:21 +0900
Message-ID: <CAM9d7chmV5itD-2K50qFcktJ2JPWdf=quDX_YL8HTYiHgzByXA@mail.gmail.com>
Subject: Re: [PATCH 1/1] perf report TUI: Remove needless 'dummy' event from menu
To:     Arnaldo Carvalho de Melo <acme@redhat.com>
Cc:     Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 6, 2020 at 8:55 PM Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
>
> Em Fri, Jul 03, 2020 at 10:44:28PM +0900, Namhyung Kim escreveu:
> > > @@ -3613,7 +3630,7 @@ int perf_evlist__tui_browse_hists(struct evlist *evlist, const char *help,
> > >         int nr_entries = evlist->core.nr_entries;
> > >
> > >  single_entry:
> > > -       if (nr_entries == 1) {
> > > +       if (perf_evlist__single_entry(evlist)) {
> >
> > But I think it cannot cover the event group case below..
>
> Right, we can fix that later, I think, my worry at this point was that
> the simplest case, which is:
>
>    # perf record
>    ^C
>    # perf report
>
> Would get that annoyance :-)

Right, then I suggest moving the 'single_entry' label to inside of the
if statement.
With that applied,

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks
Namhyung