Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp292259ybt; Mon, 6 Jul 2020 09:25:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAEsvVD38f02VSIXM0goP2c/OzHdim7I9lgbOssscMbI98tkNK0zwDme0whdG859gw1vbu X-Received: by 2002:a17:906:a84d:: with SMTP id dx13mr37195820ejb.246.1594052746927; Mon, 06 Jul 2020 09:25:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594052746; cv=none; d=google.com; s=arc-20160816; b=1JtuDK8pZYD+LOCEmITU4cIyIQVfGQ7YSBrGVX5ysX2lURVfxRfFHlxAuMyYNpes73 u3T5JbiZEG7KJY2yqsgRMVbg7vhO24EzTG2RGy3jWbubZqarBRr5QKYjXkbFqnFhrXvv 2AGzZmDE0JwRvJ9MMorW5tpGwE/1oV1Or1dGrEUHqUM8sPREWQvgLDfSUySoV28TG+LS edjFLkjvef3OTUsUTN2XEBQ8GT/YBWjbE/PIIIwp23O7ZW4Mzitjsva941j67ReafbGR gRSGYR9Yt/4Uz442FmVEDd6jTq+LmGN9xrBsS0ipxEP/grj623F+s9p/+qvWw2XDBSq/ TxVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=Fi2U8zXhpvRJ2MdC0pzuvRrfYbmlEIu/j7Yg0g2Ab90=; b=N/W9fp+absLxSnM9roADm4pKqLEGIeiUdj3VSKlizMDwimtv4pGxWgH7oznPP1SPva 5wdRPY8hDs8FKMZaki9w2mb4dsRTirJsDi8pdSGsDhE8yjLiJjH/YIhSUDHciRVpfxBf aYgTDN9r/hetwU+OI0SYyt9sFmog4/ZlLZQIHTEbtJ4+fN3b9wBUqjdbkm/VIlg4Bemp Hy31bAgymHJio9L65uILyVKaN1KrAa34scg9ciZL6yeaNsoQcQUKMNQ4dhRT8m0qCOa3 butCic6GlYWFLR/mo0DCtRS9d+34sSEbbYnPt0fWpCM6nRnGUbLKSfoZTSsoqaMbPX7B 0OZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y3si13775306edm.183.2020.07.06.09.25.23; Mon, 06 Jul 2020 09:25:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729511AbgGFQW5 (ORCPT + 99 others); Mon, 6 Jul 2020 12:22:57 -0400 Received: from mailomta13-sa.btinternet.com ([213.120.69.19]:10108 "EHLO sa-prd-fep-042.btinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729372AbgGFQW4 (ORCPT ); Mon, 6 Jul 2020 12:22:56 -0400 Received: from sa-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.38.5]) by sa-prd-fep-042.btinternet.com with ESMTP id <20200706162254.SQLR2233.sa-prd-fep-042.btinternet.com@sa-prd-rgout-002.btmx-prd.synchronoss.net>; Mon, 6 Jul 2020 17:22:54 +0100 Authentication-Results: btinternet.com; auth=pass (LOGIN) smtp.auth=j.oldman998@btinternet.com X-Originating-IP: [31.53.71.41] X-OWM-Source-IP: 31.53.71.41 (GB) X-OWM-Env-Sender: j.oldman998@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduiedrudefgddutddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecunecujfgurhephffvufffkffosedttdertdertddtnecuhfhrohhmpeflohhhnhcuqfhlughmrghnuceojhhohhhnrdholhgumhgrnhesphholhgvhhhilhhlrdgtohdruhhkqeenucggtffrrghtthgvrhhnpeegfedthfefueeihffgkeefteehuddttdefudetveelveefvdefhfejieejhffggfenucfkphepfedurdehfedrjedurdegudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopehhvghnrhihrdhhohhmvgdpihhnvghtpeefuddrheefrdejuddrgedupdhmrghilhhfrhhomhepoehjohhhnhdrohhlughmrghnsehpohhlvghhihhllhdrtghordhukheqpdhrtghpthhtohepoeguvghvvghlsegurhhivhgvrhguvghvrdhoshhuohhslhdrohhrgheqpdhrtghpthhtohepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhrgheqpdhrtghpthhtohepoehjohhhnhdrohhlughmrghnsehpohhlvghhihhllhdrtghordhukheqpdhrtghpthhtohepoehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgheq X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from henry.home (31.53.71.41) by sa-prd-rgout-002.btmx-prd.synchronoss.net (5.8.340) (authenticated as j.oldman998@btinternet.com) id 5ED9AA6E0576508D; Mon, 6 Jul 2020 17:22:54 +0100 From: John Oldman To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, John Oldman Subject: [PATCH] staging: rtl8192u: Using comparison to true is error prone Date: Mon, 6 Jul 2020 17:22:40 +0100 Message-Id: <20200706162240.2770-1-john.oldman@polehill.co.uk> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clear below issues reported by checkpatch.pl: CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8192u/r8192U_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c index c23e43b095d9..6b301acb584e 100644 --- a/drivers/staging/rtl8192u/r8192U_dm.c +++ b/drivers/staging/rtl8192u/r8192U_dm.c @@ -2240,7 +2240,7 @@ static void dm_ctstoself(struct net_device *dev) unsigned long curTxOkCnt = 0; unsigned long curRxOkCnt = 0; - if (priv->ieee80211->bCTSToSelfEnable != true) { + if (!priv->ieee80211->bCTSToSelfEnable) { pHTInfo->IOTAction &= ~HT_IOT_ACT_FORCED_CTS2SELF; return; } @@ -2944,7 +2944,7 @@ static void dm_dynamic_txpower(struct net_device *dev) unsigned int txhipower_threshold = 0; unsigned int txlowpower_threshold = 0; - if (priv->ieee80211->bdynamic_txpower_enable != true) { + if (!priv->ieee80211->bdynamic_txpower_enable) { priv->bDynamicTxHighPower = false; priv->bDynamicTxLowPower = false; return; -- 2.17.1