Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <7d2c980f071487cecfd1534adb7561b33d922af3.1593968925.git.mail@maciej.szmigiero.name>
In-Reply-To: <7d2c980f071487cecfd1534adb7561b33d922af3.1593968925.git.mail@maciej.szmigiero.name>
From:   Harry Cutts <hcutts@chromium.org>
Date:   Mon, 6 Jul 2020 11:35:43 -0700
Message-ID: <CA+jURcvL4B7xDObma5PZgTq4eaBbj6AGgBwDCSyf_mb7oRf+Lw@mail.gmail.com>
Subject: Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages
To:     "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Peter Hutterer <peter.hutterer@who-t.net>,
        linux-input <linux-input@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 5 Jul 2020 at 10:09, Maciej S. Szmigiero
<mail@maciej.szmigiero.name> wrote:
>
> These messages appear each time the mouse wakes from sleep, in my case
> (Logitech M705), every minute or so.
> Let's downgrade them to the "debug" level so they don't fill the kernel log
> by default.
>
> While we are at it, let's make clear that this is a wheel multiplier (and
> not, for example, XY movement multiplier).

Looks good to me, thanks!

Reviewed-by: Harry Cutts <hcutts@chromium.org>

Harry Cutts
Chrome OS Touch/Input team

>
> Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice")
> Cc: stable@vger.kernel.org
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> ---
>  drivers/hid/hid-logitech-hidpp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index 1e1cf8eae649..b8b53dc95e86 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct hidpp_device *hidpp)
>                 multiplier = 1;
>
>         hidpp->vertical_wheel_counter.wheel_multiplier = multiplier;
> -       hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier);
> +       hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier);
>         return 0;
>  }
>