Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp427733ybt; Mon, 6 Jul 2020 12:48:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJqJSEKFk8RBVcj43sub/rjbYMXF5clsqVelVy9MjHQSB0s04zDCKNPQzTGJ1vAjka6p90 X-Received: by 2002:a17:906:ae56:: with SMTP id lf22mr43978930ejb.59.1594064898096; Mon, 06 Jul 2020 12:48:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594064898; cv=none; d=google.com; s=arc-20160816; b=n/mBLZoVbxeFm2Qk/x0Ihq2WL5ldNeg2A1S8dVYQExphxcV/PsHQMw2PO5WTHBmygw Xdnu4BARLbmw/YvVvAz1NIjvFccwGOZw+CyPU9bJlxFUQKSTCzZij1AW8v+UKfzlC0RY RjG9oyTdnY7kjN7SWIjpOww6j4SeClcIY5YEZnnrov1TIa2D5yWINRYRV7ArLqhH/lR6 ZnNgU+b8wZPmHA3vBqnmiSKhIBfl7DNGTJrUFc/WZEkphtrW8qya2vN3IeMmzOoxYpQ1 eFIQE9qHIGORHi84+k9xR95uskeb7OXq0ZSuQe82mvuyAOjF0V4GcQbc4fXPoIe2Qj6N wG2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=TCz410iKeZ/vQ2552XR5SrpKaU/9XVuNY3h2wrfEkLI=; b=Sdi4oOKQ+n3AeoNxrj48oj/+WvqZCidye2g/Yqd4o3nV13UhZKrOqa2ZZ+R0KPHW7x a5UVpocthS8ZfHC0FmkqonTrATZtb+uDacgP/MU+WILqmqfjCKPpBQ5xB/EZGB1Oe9ZI lcFRYBJKADU8c5Z/i4Srjx3bL0xg8MOl3QIPQegOaExLdb0k69i24yy0HcPsX/Cfd8IH HZ65+y3H5/PgMX+svgSjxRrGK5KFUUF9aduuubcpGNObtmOyu/OPy/h7dsjRsSs4jqN1 Z01Eui3idCh6H+Exlc5Nm19HZhaEm6TBmduio2PWLHyIfDgKhUncKWf4fDgHwKt1+/qm smFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lw21si13612555ejb.302.2020.07.06.12.47.53; Mon, 06 Jul 2020 12:48:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgGFTrs (ORCPT + 99 others); Mon, 6 Jul 2020 15:47:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbgGFTrs (ORCPT ); Mon, 6 Jul 2020 15:47:48 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17798C061755; Mon, 6 Jul 2020 12:47:48 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 073CE127EF29F; Mon, 6 Jul 2020 12:47:46 -0700 (PDT) Date: Mon, 06 Jul 2020 12:47:46 -0700 (PDT) Message-Id: <20200706.124746.191843852351699222.davem@davemloft.net> To: matthieu.baerts@tessares.net Cc: netdev@vger.kernel.org, cpaasch@apple.com, mathew.j.martineau@linux.intel.com, kuba@kernel.org, shuah@kernel.org, mptcp@lists.01.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] selftests: mptcp: capture pcap on both sides From: David Miller In-Reply-To: <20200706124408.3118005-1-matthieu.baerts@tessares.net> References: <20200706124408.3118005-1-matthieu.baerts@tessares.net> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 06 Jul 2020 12:47:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthieu Baerts Date: Mon, 6 Jul 2020 14:44:08 +0200 > When investigating performance issues that involve latency / loss / > reordering it is useful to have the pcap from the sender-side as it > allows to easier infer the state of the sender's congestion-control, > loss-recovery, etc. > > Allow the selftests to capture a pcap on both sender and receiver so > that this information is not lost when reproducing. > > This patch also improves the file names. Instead of: > > ns4-5ee79a56-X4O6gS-ns3-5ee79a56-X4O6gS-MPTCP-MPTCP-10.0.3.1.pcap > > We now have something like for the same test: > > 5ee79a56-X4O6gS-ns3-ns4-MPTCP-MPTCP-10.0.3.1-10030-connector.pcap > 5ee79a56-X4O6gS-ns3-ns4-MPTCP-MPTCP-10.0.3.1-10030-listener.pcap > > It was a connection from ns3 to ns4, better to start with ns3 then. The > port is also added, easier to find the trace we want. > > Co-developed-by: Christoph Paasch > Signed-off-by: Christoph Paasch > Signed-off-by: Matthieu Baerts Applied, thank you.