Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp433026ybt; Mon, 6 Jul 2020 12:57:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzeLlBZ087OAMmQq0ostuQWKbyOjXbTPNOV95W96u+ToaSQZNZx8PFZVYyzPNLG6t2JUQJi X-Received: by 2002:a17:906:1386:: with SMTP id f6mr45133071ejc.66.1594065475672; Mon, 06 Jul 2020 12:57:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594065475; cv=none; d=google.com; s=arc-20160816; b=pU/vFc5A7e19uDBJLkitjdIFO/9LmPskhvT7Ss9xm/GQFnRIsse6yEzwTZEv5LhT5/ KIE5NcBf5onKt4QrYXa9Kk2Yyjku4nA/pioB5ElJlKFTcoa7wJqvJrr4jFrruguobYMW uJBmXVOSk/mWZCZ23yOFvCK7afORMdDOnUpJZEdy7wt+JrgdOuGtJqed66GcmNWw9T8v 88sqjgNLUrujqICkw/xuLoVT6eiDg/0N1+XlE8BT8m1v7Bh+J3zbwPf0iCv8lnn8D+hQ lV0FdlPtEd6FIbcvbKDlN8zTs9BshKfZf0LSAHNkp9/3Zn0h4zkm87U/GzP1J3JCFrSz eUbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=U0BZ3S1fcdpBau6AdEQ8ayWhbpvp0qe/Ol/L+MkfIvo=; b=oQyJ4E2u3tnTR3t+Q2WqfK88fsEf5DIVTQGdb5FlrhtOy5thOUGmA/WH/hwz56JqXW zM0lwUCSkzQSX1o7wk+bOkjcQDNnr7PwPZrE/GW18bg6qapvZ56g9EfKpi4V9yYQG1sy pDVSBUDywtpg5l5Eu+tbjWpeWer2/0tUG/XugnFH/lkzsfxkCClbaJrO+y9m+AiFRx3/ hcSLM2LRFnQznkIttic9/p0xh42FHIwS/cQ/mozLRacn8tm7TktTo13TvGU3SnUQ+A0S 99wJOnE5ei02fJ0ahZdDsqAX7RgGLb2G4DnKsLmrIh0tG0Ny3TvSb+NBCs/2PvaU3SEV kjVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zXqeNYPi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v2si13372630edq.127.2020.07.06.12.57.32; Mon, 06 Jul 2020 12:57:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zXqeNYPi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726540AbgGFTzY (ORCPT + 99 others); Mon, 6 Jul 2020 15:55:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:36960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725892AbgGFTzX (ORCPT ); Mon, 6 Jul 2020 15:55:23 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2408207D0; Mon, 6 Jul 2020 19:55:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594065323; bh=bgpzOSjX9GVaY9onoQwHcv3Pysfo/Zwq3IztNJwlD/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zXqeNYPi3jQcXv4g6h6rDI9h4rQ/pufzm8EQ8QbwBt0T53EsSx8QubeR8rnlhDYFu H2j5MD+KPSv3oOqPXQsLLc1W7Xxhk5T4Odfp48OLAn0kd5YwDAZS/g1TxIpKsSggaY jhAM45zdcPG/Fs+r3NiDAiOzmVYeKrv/MRNEn+H8= Date: Mon, 6 Jul 2020 21:55:20 +0200 From: Greg KH To: qiang.zhang@windriver.com Cc: balbi@kernel.org, colin.king@canonical.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] usb: gadget: function: fix missing spinlock in f_uac1_legacy Message-ID: <20200706195520.GA93712@kroah.com> References: <20200705124027.30011-1-qiang.zhang@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200705124027.30011-1-qiang.zhang@windriver.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 05, 2020 at 08:40:27PM +0800, qiang.zhang@windriver.com wrote: > From: Zhang Qiang > > Add a missing spinlock protection for play_queue, because > the play_queue may be destroyed when the "playback_work" > work func and "f_audio_out_ep_complete" callback func > operate this paly_queue at the same time. "play_queue", right? > > Cc: stable > Signed-off-by: Zhang Qiang Because you do not have a Fixes: tag in here, how far back do you want the stable patch to go to? That's why, if you can, it's always good to have a "Fixes:" tag in there to show what commit caused the problem you are fixing here. So, what commit caused this? thanks, gre gk-h