Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp483720ybt;
        Mon, 6 Jul 2020 14:23:19 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwK5QGVJUT2V7Vw3PYOAknQsnsf6OZZ9C93HN6htyXgygIiK3ee53I8vmgaRf6sKijQilwt
X-Received: by 2002:a17:906:700f:: with SMTP id n15mr34389117ejj.390.1594070599517;
        Mon, 06 Jul 2020 14:23:19 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1594070599; cv=none;
        d=google.com; s=arc-20160816;
        b=opepDZyjIeV1Q6p6ZJT2d2QKUx3gq/0nrYFTccrrs3IwaDUtkeRgYz6aKhLoJCMAch
         e7eWFzLrg4/8LcPovbhY69KqInJaDttFt9T9gl7GGGfB5c3hdBiZvj74HRqcheWZBUtd
         1XvImOrBwTo0BdfW+hpyR4uyA9/HMtzg8TpO1ykgEBlFg76pAwrp2/1kjecUPST6cYWj
         LCKrMouseHw/zfNMbhZYAHNymR9x03MoMfbf4rUf374m67Jvohb3sh22FTuhV1qvSzEf
         Luc0++2zDmTQS3NkVxxBjPcJJFiwSSKe/GMGxgO1r9bnPvM+RvQ7q5hXHNxOLjL5f3Uh
         c13g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature;
        bh=bvNzU1/i5HWoFHcEdnm+49UroNCpJNDXqIVNrFmzAkA=;
        b=Dt/IUjyVuMjGj+Z0yvCdCGFcJblwG/wumkuMPghFu9UNTK+JrbzVEwlu2S5tah0p4S
         vVoDl8juFhxTrwnpx4Y/CFZjZkOvZJ8VwvZAOF9s1n3uICWVFifHIULcWg4PC23wW1cK
         xGU3HD7VMS654JvbZGPyaZrB2fZcO4Dl5XH0SDgPm+M1mCsQQvFdZ7nPRQeXIhzKsPtr
         GvdHElJRafICdj+9aiuQLLqn4cx3WF9W3UREubIYotA+VBw6e4MzZyDJd+jT96Goanql
         jQhmt2ZQhpyOa9rLMniK0e66s7X1kKEax6dvdu6DkptYyCL0oMfYG4u3QbF6elhelR+7
         pGHQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=xJ7t+EAb;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id w18si6690432eds.406.2020.07.06.14.22.55;
        Mon, 06 Jul 2020 14:23:19 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=xJ7t+EAb;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726701AbgGFVV5 (ORCPT <rfc822;chenhe.dev@gmail.com>
        + 99 others); Mon, 6 Jul 2020 17:21:57 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35124 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725860AbgGFVV5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Jul 2020 17:21:57 -0400
Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59B92C061755
        for <linux-kernel@vger.kernel.org>; Mon,  6 Jul 2020 14:21:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=bvNzU1/i5HWoFHcEdnm+49UroNCpJNDXqIVNrFmzAkA=; b=xJ7t+EAbs3c5bxug+tOGtMf/au
        SHuySTMsBOIMOHnYrHMerQRGhyE+XWYqRkj73GN+Udbpvn3hcpDtrAo+XOaxfuFMH6kfCUwZXRdn2
        sTaN0T5WXA9TXMzIGi7ByozjlaaDUolxvWVYIRX7cj12B3hYnZte/CegPBlrnjy+Ud8w/T9kfZzQ0
        2jf9LBAtSZ/ZecTaqISO5asKJk3IRzI8XB1H4fEE3GGCurUiNMVfrU5MVPcB066nuK2S5sWXisasJ
        nVCtjS7QgCHGSGPmxspilRORy82mvEqCsu0qYmbNwDRikilY+uavamX43NOdGsOcbMKdzHOVorox1
        dh7+ye3A==;
Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net)
        by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux))
        id 1jsYYg-0004Ky-Gh; Mon, 06 Jul 2020 21:21:50 +0000
Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000)
        id B02BF980DD2; Mon,  6 Jul 2020 23:21:48 +0200 (CEST)
Date:   Mon, 6 Jul 2020 23:21:48 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     "Ahmed S. Darwish" <a.darwish@linutronix.de>
Cc:     Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        "Sebastian A. Siewior" <bigeasy@linutronix.de>,
        Steven Rostedt <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 06/20] seqlock: Extend seqcount API with associated
 locks
Message-ID: <20200706212148.GE5523@worktop.programming.kicks-ass.net>
References: <20200630054452.3675847-1-a.darwish@linutronix.de>
 <20200630054452.3675847-7-a.darwish@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200630054452.3675847-7-a.darwish@linutronix.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 30, 2020 at 07:44:38AM +0200, Ahmed S. Darwish wrote:
> +#include <linux/seqlock_types_internal.h>

Why? why not include those lines directly here? Having it in a separate
file actually makes it harder to read.