Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 6 Jul 2020 22:06:48 +0000
From:   Wei Yang <richard.weiyang@gmail.com>
To:     "Kirill A. Shutemov" <kirill@shutemov.name>
Cc:     Wei Yang <richard.weiyang@linux.alibaba.com>,
        akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
        yang.shi@linux.alibaba.com, vbabka@suse.cz, willy@infradead.org,
        thomas_os@shipmail.org, thellstrom@vmware.com,
        anshuman.khandual@arm.com, sean.j.christopherson@intel.com,
        aneesh.kumar@linux.ibm.com, peterx@redhat.com, walken@google.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, digetx@gmail.com
Subject: Re: [RESEND Patch v2 0/4] mm/mremap: cleanup move_page_tables() a
 little
Message-ID: <20200706220648.qfzwnitoswbbkdnw@master>
Reply-To: Wei Yang <richard.weiyang@gmail.com>
References: <20200626135216.24314-1-richard.weiyang@linux.alibaba.com>
 <20200706100819.flwgozlstn3zl66u@box>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200706100819.flwgozlstn3zl66u@box>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 06, 2020 at 01:08:19PM +0300, Kirill A. Shutemov wrote:
>On Fri, Jun 26, 2020 at 09:52:12PM +0800, Wei Yang wrote:
>> move_page_tables() tries to move page table by PMD or PTE.
>> 
>> The root reason is if it tries to move PMD, both old and new range should be
>> PMD aligned. But current code calculate old range and new range separately.
>> This leads to some redundant check and calculation.
>> 
>> This cleanup tries to consolidate the range check in one place to reduce some
>> extra range handling.
>
>The patchet looks good to me. I have few nits, but nothing substantial.
>
>Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>

Hi, Kirill

Thanks for your review.

Andrew,

Do you want me to send another version or you would like to adjust it
directly?

>-- 
> Kirill A. Shutemov

-- 
Wei Yang
Help you, Help me