Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 7 Jul 2020 10:53:19 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Joonsoo Kim <js1304@gmail.com>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: linux-next: Tree for Jul 6 (mm/memory_failure.c)
Message-ID: <20200707105319.217409ab@canb.auug.org.au>
In-Reply-To: <20200707003500.GA27886@js1304-desktop>
References: <20200706174001.2d316826@canb.auug.org.au>
        <d458c18d-9c5e-9c45-0d65-e317571b6d56@infradead.org>
        <20200707003500.GA27886@js1304-desktop>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/Bt80v1CvXV=K6Q+g4oLKLfr";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/Bt80v1CvXV=K6Q+g4oLKLfr
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi all,

On Tue, 7 Jul 2020 09:35:15 +0900 Joonsoo Kim <js1304@gmail.com> wrote:
>
> On Mon, Jul 06, 2020 at 09:59:06AM -0700, Randy Dunlap wrote:
> >=20
> > on i386:
> >=20
> > when CONFIG_MIGRATION is not set/enabled:
> >=20
> > ../mm/memory-failure.c: In function =E2=80=98new_page=E2=80=99:
> > ../mm/memory-failure.c:1688:9: error: implicit declaration of function =
=E2=80=98alloc_migration_target=E2=80=99; did you mean =E2=80=98alloc_migra=
te_target=E2=80=99? [-Werror=3Dimplicit-function-declaration]
> >   return alloc_migration_target(p, (unsigned long)&mtc);
> >          ^~~~~~~~~~~~~~~~~~~~~~
>=20
> Thanks for reporting.
>=20
> Below is the fix for this error.
> Andrew, Could you squash this fix into the patch,
> "mm-migrate-make-a-standard-target-allocation-function.patch"?
>=20
> Thanks.
>=20
>=20
> ------------------->8------------------- =20
> From 5fac269125dfb2d03e38a75319305e0e70b23a4b Mon Sep 17 00:00:00 2001
> From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Date: Tue, 7 Jul 2020 09:16:58 +0900
> Subject: [PATCH] mm/migrate: fix for
>  mm-migrate-make-a-standard-target-allocation-function.patch in mm tree
>=20
> new_page_nodemask() is renamed to alloc_migration_target in
> mm-migrate-make-a-standard-target-allocation-function.patch, but,
> one declaration for !CONFIG_MIGRATION case is missed. This patch fixes it.
>=20
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> ---
>  include/linux/migrate.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/include/linux/migrate.h b/include/linux/migrate.h
> index 5e9c866..cc56f0d 100644
> --- a/include/linux/migrate.h
> +++ b/include/linux/migrate.h
> @@ -60,8 +60,8 @@ static inline int migrate_pages(struct list_head *l, ne=
w_page_t new,
>  		free_page_t free, unsigned long private, enum migrate_mode mode,
>  		int reason)
>  	{ return -ENOSYS; }
> -static inline struct page *new_page_nodemask(struct page *page,
> -		int preferred_nid, nodemask_t *nodemask)
> +static inline struct page *alloc_migration_target(struct page *page,
> +		unsigned long private)
>  	{ return NULL; }
>  static inline int isolate_movable_page(struct page *page, isolate_mode_t=
 mode)
>  	{ return -EBUSY; }
> --=20
> 2.7.4
>=20

I have added that to linux-next today.

--=20
Cheers,
Stephen Rothwell

--Sig_/Bt80v1CvXV=K6Q+g4oLKLfr
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl8Dx38ACgkQAVBC80lX
0GzBpwf/TGUIgs/Kd6fLMDYUq2Jne1llwy+V11XxKr0qjCuBLGV66Jq64I2QsjsB
AwiAyQRWaS7MWWom4k0OU3ulFCCYyFDC4ojD/kx+9VFbZyWvaWGhgM7yC1n4LPu0
XlyDxkBZDGm0IwBvSRI4BHzM61a6VF1dueUrwpgnTDyU2sJrNzTRwlqm5GEuy2yv
doV9z55KFAoo2W14t+mVlvfeESJrUts+cNttK5Cn5NlU/a/d6jfe5ipRlDxeI5vt
aNz/Odg8qAVr3FkHKwnHlYq1Vj6qcY/FzwKSo/lOA0fYXpJZehY1HsGyzZxFl8o2
njmdZCi65cnEqXvbgr507B/Yabc/3A==
=oiE+
-----END PGP SIGNATURE-----

--Sig_/Bt80v1CvXV=K6Q+g4oLKLfr--