Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp648030ybt; Mon, 6 Jul 2020 19:17:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhizLzSTgrw23Or8jqk40A/rgbt57y14BHBO/w5nBEhQBE0dq0wG3cfz6qA1DxNtmexNk+ X-Received: by 2002:a50:dacf:: with SMTP id s15mr61558316edj.136.1594088247767; Mon, 06 Jul 2020 19:17:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594088247; cv=none; d=google.com; s=arc-20160816; b=RTu1lSakvZau7Bm91bIIqLGjRocp/GakKwWy74P5are6vmmsWls3M1WOmOgpGUlW81 Q6nHfUDOnylxfmvsDW9Xt6tnzfn1ZUfZkOuLRZmyoSC06XgJIdflfOOurEVzjdam9JBl GjR7hGyXKd6HIkv4kg5c3Rj9eX3NAjaNInoa+RKehmmy7lcpC1QUF5eWVFVONK2wh8Z4 4lsGBfk/jPKzwi/G2vSLki/78R4WgJvC+Nd0pRiL2/Gx0MxwyFfc+uP42DSbfp1AVJ9u QfnTJZ07DNT5ZFUYnwsA1QoyTXHx6NjXjmHdYSZVDc1L8AkPetz+GkK0RFkl/sKdYsLq yfFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:ironport-sdr:ironport-sdr; bh=4WmIOoFQLEblPmsUoZ1R3TNi4GZPqsd/2wG3q9RCQlo=; b=dLhtcO18JkRGL5HwtKCsxDePpT96hwplfpjjROboQcDUnmpqvqPqIkTRApvjwH79MM JmQxne+dqCPBvJckHulGU8TMoJTHFwSDd8CQC5XYG2jo6a+b+og16M9vXCulsvcJaXZD gO/z7Z1o3Ci4+MK7qhdGTM4HgaHX3ZqQU9jO7X3aRfMtXOpxe6yYBm1S1qgdEUkJ5NgR ob/qGAWEcWx/KgCrxImN4tomHMpyeyKsMlZ++BjVcmL+qyoNrTZ0gyIqGK/94mTsxJ/Y OWufHX29Z381us7MUl3rMzsbPPDWpfubwHzJ7ukdYFYB2wXwsiFipRj7ZJnipJKNWgMg BFmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id df7si10233149edb.462.2020.07.06.19.17.05; Mon, 06 Jul 2020 19:17:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728231AbgGGCPj (ORCPT + 99 others); Mon, 6 Jul 2020 22:15:39 -0400 Received: from mga02.intel.com ([134.134.136.20]:6131 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726434AbgGGCPh (ORCPT ); Mon, 6 Jul 2020 22:15:37 -0400 IronPort-SDR: N+FFA9emvi8ck8zQGlpJV5+5Hjj1hVEAbnB8GS1ho7iaTM6oCgTzL3OgyTS1HBTmCPxJxV/Q42 EPc0dzJanMcA== X-IronPort-AV: E=McAfee;i="6000,8403,9674"; a="135773849" X-IronPort-AV: E=Sophos;i="5.75,321,1589266800"; d="scan'208";a="135773849" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 19:15:37 -0700 IronPort-SDR: 9ZYdVverSyw+u3Za8MVw+ijVSrccrbAuYHQN729lvemfQ4/5iVg707QpK2r9am9Bbl25/+FM3P Y/UrocfzT/Cw== X-IronPort-AV: E=Sophos;i="5.75,321,1589266800"; d="scan'208";a="266694312" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.16]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 19:15:37 -0700 Subject: [PATCH v2 09/12] libnvdimm: Convert to DEVICE_ATTR_ADMIN_RO() From: Dan Williams To: linux-nvdimm@lists.01.org Cc: Vishal Verma , Dave Jiang , Ira Weiny , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 06 Jul 2020 18:59:21 -0700 Message-ID: <159408716166.2385045.5987808622423332941.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <159408711335.2385045.2567600405906448375.stgit@dwillia2-desk3.amr.corp.intel.com> References: <159408711335.2385045.2567600405906448375.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.18-3-g996c MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move libnvdimm sysfs attributes that currently use an open coded DEVICE_ATTR() to hide sensitive root-only information (physical memory layout) to the new DEVICE_ATTR_ADMIN_RO() helper. Cc: Vishal Verma Cc: Dave Jiang Cc: Ira Weiny Signed-off-by: Dan Williams --- drivers/nvdimm/namespace_devs.c | 2 +- drivers/nvdimm/pfn_devs.c | 2 +- drivers/nvdimm/region_devs.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c index ae155e860fdc..6da67f4d641a 100644 --- a/drivers/nvdimm/namespace_devs.c +++ b/drivers/nvdimm/namespace_devs.c @@ -1309,7 +1309,7 @@ static ssize_t resource_show(struct device *dev, return -ENXIO; return sprintf(buf, "%#llx\n", (unsigned long long) res->start); } -static DEVICE_ATTR(resource, 0400, resource_show, NULL); +static DEVICE_ATTR_ADMIN_RO(resource); static const unsigned long blk_lbasize_supported[] = { 512, 520, 528, 4096, 4104, 4160, 4224, 0 }; diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c index 34db557dbad1..3e11ef8d3f5b 100644 --- a/drivers/nvdimm/pfn_devs.c +++ b/drivers/nvdimm/pfn_devs.c @@ -218,7 +218,7 @@ static ssize_t resource_show(struct device *dev, return rc; } -static DEVICE_ATTR(resource, 0400, resource_show, NULL); +static DEVICE_ATTR_ADMIN_RO(resource); static ssize_t size_show(struct device *dev, struct device_attribute *attr, char *buf) diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index 4502f9c4708d..20ff30c2ab93 100644 --- a/drivers/nvdimm/region_devs.c +++ b/drivers/nvdimm/region_devs.c @@ -605,7 +605,7 @@ static ssize_t resource_show(struct device *dev, return sprintf(buf, "%#llx\n", nd_region->ndr_start); } -static DEVICE_ATTR(resource, 0400, resource_show, NULL); +static DEVICE_ATTR_ADMIN_RO(resource); static ssize_t persistence_domain_show(struct device *dev, struct device_attribute *attr, char *buf)