Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6779 driver
To:     Neal Liu <neal.liu@mediatek.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        lkml <linux-kernel@vger.kernel.org>,
        linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com
References: <1594027693-19530-1-git-send-email-neal.liu@mediatek.com>
 <1594027693-19530-3-git-send-email-neal.liu@mediatek.com>
 <dd03ec1e-e511-4c13-4e12-a9f8ec407326@infradead.org>
 <1594092631.20820.4.camel@mtkswgap22>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <eb2eaab3-1ecc-d2c8-fc40-5bbe51ee31c4@infradead.org>
Date:   Mon, 6 Jul 2020 20:32:57 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <1594092631.20820.4.camel@mtkswgap22>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/6/20 8:30 PM, Neal Liu wrote:
> Hi Randy,
> 
> Thanks for your review.
> 
> On Mon, 2020-07-06 at 09:13 -0700, Randy Dunlap wrote:
>> On 7/6/20 2:28 AM, Neal Liu wrote:
>>> diff --git a/drivers/soc/mediatek/devapc/Kconfig b/drivers/soc/mediatek/devapc/Kconfig
>>> new file mode 100644
>>> index 0000000..b0f7d0e
>>> --- /dev/null
>>> +++ b/drivers/soc/mediatek/devapc/Kconfig
>>> @@ -0,0 +1,17 @@
>>> +config MTK_DEVAPC
>>> +	tristate "Mediatek Device APC Support"
>>> +	help
>>> +	  Device APC is a HW IP controlling internal device security.
>>
>> preferably:               s/HW/hardware/
>>
>>> +	  MediaTek bus frabric provides TrustZone security support and data
>>
>> 	               fabric
>>
>>> +	  protection to prevent slaves from being accessed by unexpected
>>> +	  bus masters.
>>> +	  Device APC prevents malicious access to internal devices.
>>> +
>>> +config DEVAPC_MT6779
>>> +	tristate "Mediatek MT6779 Device APC driver"
>>> +	select MTK_DEVAPC
>>> +	help
>>> +	  Say yes here to enable support Mediatek MT6779 Device APC driver.
>>
>> 	                         support for Mediatek
>>
>>> +	  This driver mainly used to handle the violation with 1 DEVAPC AO/PDs.
>>
>> 	  This driver is mainly used                           ^^^^^^^^^^^^^^^^
>>
>> 	                      What is that meaningless string of chars? ^^^^^^^
> 
> I did not see any meaningless string of chars from my original patch.
> Is there something wrong?

To someone who is reading the Kconfig help text but is unfamiliar with this device,
I would say that        "1 DEVAPC AO/PDs"                    is not helpful at all.

> [1] https://lkml.org/lkml/2020/7/6/168
> 
>>
>>> +	  The violation information are logged for further analysis or
>>
>> 	                            is
>>
>>> +	  countermeasures.
>>
>> thanks.
> 


thanks.
-- 
~Randy