Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Pawel Laszczak <pawell@cadence.com>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "colin.king@canonical.com" <colin.king@canonical.com>,
        "jpawar@cadence.com" <jpawar@cadence.com>,
        "ben.dooks@codethink.co.uk" <ben.dooks@codethink.co.uk>,
        "kurahul@cadence.com" <kurahul@cadence.com>,
        "sparmar@cadence.com" <sparmar@cadence.com>
Subject: Re: [PATCH 1/9] usb: cdns3: Improvement: removed
 cdns3_get_current_role_driver function.
Thread-Topic: [PATCH 1/9] usb: cdns3: Improvement: removed
 cdns3_get_current_role_driver function.
Thread-Index: AQHWT3AWQFugyHyfQkS1wLAPetiZuqj7rnOA
Date:   Tue, 7 Jul 2020 06:20:00 +0000
Message-ID: <20200707062009.GB16073@b29397-desktop>
References: <20200701062004.29908-1-pawell@cadence.com>
 <20200701062004.29908-2-pawell@cadence.com>
In-Reply-To: <20200701062004.29908-2-pawell@cadence.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <599417C8E315CF4BBD06B0FB4589D64F@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fc8d6465-2155-4184-fe6c-08d8223dc737
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2020 06:20:00.2126
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pzrYOxsk3iQK1wzZHCCoG2CslLMBj/uBBONlQaVvTmskt8IqFQyGkVV1xl0kLHb0SrQeZB/ca7DiKcDv0TEl6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6280
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-07-01 08:19:56, Pawel Laszczak wrote:
> Function is not used in driver so it can be removed.
>=20
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
>  drivers/usb/cdns3/core.c | 7 -------
>  1 file changed, 7 deletions(-)
>=20
> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
> index 19bbb5b7e6b6..eaafa6bd2a50 100644
> --- a/drivers/usb/cdns3/core.c
> +++ b/drivers/usb/cdns3/core.c
> @@ -27,13 +27,6 @@
> =20
>  static int cdns3_idle_init(struct cdns3 *cdns);
> =20
> -static inline
> -struct cdns3_role_driver *cdns3_get_current_role_driver(struct cdns3 *cd=
ns)
> -{
> -	WARN_ON(!cdns->roles[cdns->role]);
> -	return cdns->roles[cdns->role];
> -}
> -

Change the title for the patch, otherwise:
Reviewed-by: Peter Chen <peter.chen@nxp.com>

--=20

Thanks,
Peter Chen=