Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp790543ybt; Mon, 6 Jul 2020 23:52:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfsRF80uaO0ABB99frDUO0EUW4D1oC5xPe6J1io67KUTkyz2JWtS8VQCRlDMOJp5RW2ZG5 X-Received: by 2002:a05:6402:234b:: with SMTP id r11mr32408029eda.5.1594104771928; Mon, 06 Jul 2020 23:52:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594104771; cv=none; d=google.com; s=arc-20160816; b=j2SvtEeM94KeQk56yL6ZpnD0ZwZd3VL3TtLhAYnhx9dGwovIZOG8jmFDnohiyYgN7B XKDujr0kqOaoFUhOtSW5UXtCIWGHD4tYYgpP2WOlKSFoE8RsFSESNPbDkSoLRU+vaZq7 WiDFFWh9lgbAcX1maw0i5yxb7RoFo79b1qH2+byijB7+XMZ6HTSRJuSKJC0BD+XCDymI U2PhhCNAtfasS77DLk1/iQwsuMrYFftXE+qUI04dBLRiW/6rajf4kiBz7lPYDezQau4w 3yXlQrJeTrFVnTVuX6kzkjKVyKM9TYFGc256xkx9O9uc8C6ZMP821HLswKQP4Jsgk1y0 xiig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KrM7gGxbghme4fWKw/wXBPFINWWyd1DGk4P9kl0zsWc=; b=D1Iw7j4+IyefgN7ilVWIy07Amy5ZQnY8eqK2cbIMJaG20szkbXHZiMQ9cwy/DmVcFE SSmWmmXNXJhMfq4gdwAGjyRwX8BtIDnVr7ufZBbhpkwnzsN9/Ip+3ssbqUOPWCmKCFKd Vc4Z1cPZ3dHlX4EjDAn5XHLNZj/E8YQn5mstME+0UzmZAzjcsi8qr4kmNoU4Fgcca64k w2dV5RTmFVPgxavesY3w6WGj5z3rUxbK+pFGUaIpr1dbOKzn88H8M2pcCJCe40eEEB8d SRV1wgiRP1GKgYqqvV1X87LhbdXJG7Nld15CzimLoTc9UXHQL84VeFa9GR4Vn1ZfbHs+ OV+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dPCYbO3B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v8si14605492edr.557.2020.07.06.23.52.28; Mon, 06 Jul 2020 23:52:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dPCYbO3B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728326AbgGGGvn (ORCPT + 99 others); Tue, 7 Jul 2020 02:51:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:41568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727850AbgGGGvm (ORCPT ); Tue, 7 Jul 2020 02:51:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DAC78206F6; Tue, 7 Jul 2020 06:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594104702; bh=gE9m6IM8qBh8PWfvrR+CeLupA3RereV+AmgFwG46lIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dPCYbO3B95dh7APnaAzWwVYxX65SkFvKxNHrM/HhbdhA+v2s7QmKQgD1cSowRMdl/ ZxaxjrsWGMJDJj84qxzhb3QLaBGMrob9Ugo/19YfH4D2nahXscn8x4zUJRQFyq6xVq 2+muqNyd1E+aKGU/LhTnReAtPh/Ju/MPFCUBmNQw= Date: Tue, 7 Jul 2020 08:51:39 +0200 From: Greg KH To: "Zhang, Qiang" Cc: "balbi@kernel.org" , "colin.king@canonical.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: =?utf-8?B?5Zue5aSNOiBbUEFUQ0ggdjNdIHVz?= =?utf-8?Q?b=3A?= gadget: function: fix missing spinlock in f_uac1_legacy Message-ID: <20200707065139.GA5233@kroah.com> References: <20200705124027.30011-1-qiang.zhang@windriver.com> <20200706195520.GA93712@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Tue, Jul 07, 2020 at 02:28:36AM +0000, Zhang, Qiang wrote: > Hi Greg KH > In the early submission: > "commit id c6994e6f067cf0fc4c6cca3d164018b1150916f8" which add USB Audio Gadget driver " > the "audio->play_queue" was protected from "audio->lock" > spinlock in "playback_work" func, But in "f_audio_out_ep_complete" func > there is no protection for the operation of this "audio->play_queue". there > are missing spinlock, Fix tags should add up here commit? I really do not understand what you are asking here, sorry. greg k-h