Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp794773ybt; Tue, 7 Jul 2020 00:00:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymumqo+iyhSL3ImQgsp4QiQ29IXAnGPBIgL5E8J5T/lcCqsiHjDNwtkyJrSgHuvEemZ72h X-Received: by 2002:a17:906:9348:: with SMTP id p8mr23805658ejw.467.1594105248109; Tue, 07 Jul 2020 00:00:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594105248; cv=none; d=google.com; s=arc-20160816; b=PSu+IDFaHH1Cn8/g8YN3J8NKjvMEUH3V1inSgO+6HN0VPJJUCyAI26o6v8m30gKYPb EnhW0cGb3z+Hqg0jCU8V2viOy63+CDH2G1rS41u0i/bRJyXA8cEKgKnIMOV/O74FDAB6 aHSCmWAeDlnNaJ2W4OQftdTne6ewPtlwhn13xp7v4mRKd33enT+iwDZCqmEOuf17GCpV S8R3n6ORMVnDTZ4awMAEhGc3gYbpae3bpOsVLS1A2iLwKciedO6nEzfaL/Lnw6fkTri8 dl7eftLYDcXoWXCYlbSj7LesMuJqCz9hComUfNX6cnZntGleKI+gW64eyOoWAARb2xtK TdAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=mEj4vs6VY+zHkJKWn7vnTHXHnPac4LROCsAlctmEgcM=; b=URtUHKQpD3aZIAbn2yKVQBv4I3qLEVktqZ+nXf2bB1aWkyK1h38X9zo725/NVxI3gW /jC3m/fcG/oRQYBPQomMx++cTOqzRUxn5OuaiJsDwvtM+NcfvCb5o+6boE8J02UY1iBj 0RHPBhZLDcUOfpp7UI2CchhIpOuA9gjOCcWs5gddDFbuyA051KCTxvM9VBwsDHZJtkXM da6j7fACh6d89oYvavSA6gwgQhCpKvIFoyo9aDW4se2Odv1zmVOOVJl0oluWVSWzOKIF 4kt7lBE7DAKhRWntzEbzs0pqi/km286piEUyAXwVvXKZfiJBoy3KpbwfEJggMJBbgCpY 9xxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Sv9azsod; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a13si15229693edn.461.2020.07.07.00.00.24; Tue, 07 Jul 2020 00:00:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Sv9azsod; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728260AbgGGG5U (ORCPT + 99 others); Tue, 7 Jul 2020 02:57:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:44778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726788AbgGGG5U (ORCPT ); Tue, 7 Jul 2020 02:57:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96CAE206E9; Tue, 7 Jul 2020 06:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594105039; bh=bhpKlvwim1fVN7Nr9utrslL9C71fMybXOu7IHiu12ZY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Sv9azsodDdkbgvmgClRu8annhzLJ713NZmUNor3hMgN/ovHsD6ze+jFAhOi3SJn7C 3hJdOkh1jmNQuzTyMkJDCLmIDDh29V89izDTDKzMyFeCT00XcFNAmSVoC2CB249Ecq PbG+rfd6l4/c6bWi7Z0mln5YApw3m/BIBITKuEwY= Date: Tue, 7 Jul 2020 08:57:16 +0200 From: Greg Kroah-Hartman To: Rajat Jain Cc: David Woodhouse , Lu Baolu , Joerg Roedel , Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Raj Ashok , lalithambika.krishnakumar@intel.com, Mika Westerberg , Jean-Philippe Brucker , Prashant Malani , Benson Leung , Todd Broch , Alex Levin , Mattias Nissler , Rajat Jain , Bernie Keany , Aaron Durbin , Diego Rivas , Duncan Laurie , Furquan Shaikh , Jesse Barnes , Christian Kellner , Alex Williamson , oohall@gmail.com, Saravana Kannan , Suzuki K Poulose , Arnd Bergmann , Heikki Krogerus , stable@vger.kernel.org Subject: Re: [PATCH RESEND v2] PCI: Add device even if driver attach failed Message-ID: <20200707065716.GA5622@kroah.com> References: <20200706233240.3245512-1-rajatja@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200706233240.3245512-1-rajatja@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 06, 2020 at 04:32:40PM -0700, Rajat Jain wrote: > device_attach() returning failure indicates a driver error while trying to > probe the device. In such a scenario, the PCI device should still be added > in the system and be visible to the user. > > This patch partially reverts: > commit ab1a187bba5c ("PCI: Check device_attach() return value always") > > Signed-off-by: Rajat Jain > Reviewed-by: Greg Kroah-Hartman > --- > Resending to stable, independent from other patches per Greg's suggestion > v2: Add Greg's reviewed by, fix commit log This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.