Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: GomxtYGTMp9nhhNCZZgOBmd3uitn0olFRjumTfUJb4fQfWguwGgp4BLrpfq3CgMlY+GvdcnIU2
 E3m6LIYD6WdA==
IronPort-SDR: 7lweS80P5ckMtp50mbg/VWoNPyMhE1JXIAcCTP7xmfNweRPorTbuXso1wFZuqw7JY7k/BIyFQx
 XPJxxdHE0MdQ==
Cc:     baolu.lu@linux.intel.com, David Woodhouse <dwmw2@infradead.org>,
        Joerg Roedel <joro@8bytes.org>,
        iommu@lists.linux-foundation.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Kai Heng Feng <kai.heng.feng@canonical.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Sun, Jian" <jian.sun@intel.com>
Subject: Re: [Issue]platform/x86: iommu: System can't shutdown because iommu
 driver keeps checking the status of DMA_GSTS_TES
To:     Koba Ko <koba.ko@canonical.com>
References: <CAJB-X+Ww=bZN2qZ=e=4EkN_RUTiZxHxkdnHh50y9iVqZmT_XQg@mail.gmail.com>
 <111dde48-8018-6d74-5df8-1534143f4de6@linux.intel.com>
 <CAJB-X+WgjKR3PgoF_tn_g__+agCSGJpyB8sh+A62gs0qztDuVQ@mail.gmail.com>
 <66cacbab-b04d-33f3-053e-4d554ac7c662@linux.intel.com>
 <CAJB-X+Uo2yw+SC6X2sfDsG9YusyL9iJAuR0wG_L+KYtSkz=Cmg@mail.gmail.com>
From:   Lu Baolu <baolu.lu@linux.intel.com>
Message-ID: <1b559268-5bf7-a185-4492-c34023b78689@linux.intel.com>
Date:   Tue, 7 Jul 2020 15:23:57 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAJB-X+Uo2yw+SC6X2sfDsG9YusyL9iJAuR0wG_L+KYtSkz=Cmg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Koba KO,

On 2020/7/7 11:27, Koba Ko wrote:
> Dear Baolu,
> On Tue, Jun 30, 2020 at 3:52 PM Lu Baolu <baolu.lu@linux.intel.com> wrote:
>>
>> Hi Koba,
>>
>> On 2020/6/30 15:31, Koba Ko wrote:
>>> On Mon, Jun 15, 2020 at 3:20 PM Lu Baolu <baolu.lu@linux.intel.com> wrote:
>>>>
>>>> Hi Koba Ko,
>>>>
>>>> On 2020/6/15 11:19, Koba Ko wrote:
>>>>> hi All,
>>>>> I have a machine and there's only intel gpu.
>>>>> the secureboot and vt-d is enabled in BIOS.
>>>>> On the Ubuntu desktop, I do s2idle first and restart the machine.
>>>>> The machine can't restart successfully, so I need to press the
>>>>> power button to shutdown.
>>>>> I tried  each of the following and the issue can't be triggered.
>>>>> 1. disable secure boot in BIOS.
>>>>> 2. intel_iommu=off.
>>>>> 3. intel_iomm=igfx_off.
>>>>> 4. nomodeset
>>>>> 5. i915.modeset=0.
>>>>>
>>>>> After I investigate further, find inte_iommu keeps checking the status
>>>>> of DMA_GSTS_TES.
>>>>> During the procedure of restart, the driver would disable iommu
>>>>> translation and
>>>>> check status of DMA_GSTS_TES until status of DMA_GSTS_TES is 0.
>>>>>
>>>>> If you need more information, I can provide it.
>>>>
>>>> Do you mind telling what platform is it?
>>>>
>>>> Best regards,
>>>> baolu
>>> Hi Baolu,
>>> Sorry, i missed your email.
>>> I'm running on TGL.
>>> My colleague has reported this on bugzilla.
>>> Have tested your patch and it works fine.
>>> https://bugzilla.kernel.org/show_bug.cgi?id=208363
>>>
>>> Could you explain more about these patches!? Why do we need  a flag
>>> for active iommu!?
>>>
>>
>> We're still investigating this issue. If we find out more, I'll let you
>> know. Thanks a lot for the reporting.
>>
>> Best regards,
>> baolu
>>
> Sorry for disturbing,
> Do you have any updates for this issue?!
> https://bugzilla.kernel.org/show_bug.cgi?id=208363

We are in process of collecting what kind of platforms are affected. I
will push the workaround patch to the community as soon as we are done.

Best regards,
baolu