Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp814708ybt; Tue, 7 Jul 2020 00:34:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIEJ/hwM9Z0ZDZ6ni9xzCPH6syDiac7f/QKNlZa1J53qWErDtMB1zOT9X3SAixpgsQ+SlE X-Received: by 2002:a17:906:ce32:: with SMTP id sd18mr47884249ejb.228.1594107293766; Tue, 07 Jul 2020 00:34:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594107293; cv=none; d=google.com; s=arc-20160816; b=qvNC282Fo1kNCSoRGe4tLEuNhfoR3DGGnZ+2r82S5a1+ZAyMGHm4nfFKNBWLsqadLX NNSKSF0RGCHycZtSCRfWzELdTO1cVCTpjH7xvzJGJ4yIk8rZy3we4gVHipFSqdL9v9yu zoYwIQybi6gBC2cTH5pNrDD1JMjbd/hLWCPKyxIIQwZI5RyZBJ0MyTBwJkp/T13cL4v8 yl/U4U32jGrTl7Hv9FK7ZMM/L5xb8dPbq7XfUtwDbatUU6+vS16/sggkrPeuxb0zL0yk BM1z4zW2wwouyEI69yyCRj4j0T2+el7ihTQnOvBakB212ARROf3BAvKeVhsBbYZJprQC hnVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from :dkim-signature:dkim-signature:date; bh=NThXY8gXYlYvd8/JfuwmR/mVqUOlROOhRtkmtCJ5LSs=; b=lydEy2QYRbwKYLBJEij1X/L1Qmha+xWIKND6W1oba7TC0YMfqlriYbRW7+wpVVe+ml UCcL5VKfOg3W0IsqFDpziSuEdNJWejeFzIXjCDMjKMu/b9RQObQNLsXWy+9CnxP+EBJe 6mvax04ulxGKapmy0MbrFEK0LkY2CyLBEi/qgyiZGHeuH3k7f+zKO4ugFyBr5QupUHur Kao0ZDYToI+J/2ivsgVD9bDSNHnwgnPJcfFYbwU/Y25RjUXMFXYF7W1hB5Mgiw/gjA1f +HKEsdF8DTnN+DnfuRLWnZtD44wkA6tOnv5l4KGZayoJpvglzBSc/bCeDkjC+uHjtAV9 4rUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=zmmLp4Dx; dkim=neutral (no key) header.i=@linutronix.de header.b=E3VVJSWV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id uz6si13783125ejb.50.2020.07.07.00.34.30; Tue, 07 Jul 2020 00:34:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=zmmLp4Dx; dkim=neutral (no key) header.i=@linutronix.de header.b=E3VVJSWV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728014AbgGGHeU (ORCPT + 99 others); Tue, 7 Jul 2020 03:34:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbgGGHeU (ORCPT ); Tue, 7 Jul 2020 03:34:20 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FAC2C061755 for ; Tue, 7 Jul 2020 00:34:20 -0700 (PDT) Date: Tue, 7 Jul 2020 09:34:16 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1594107258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NThXY8gXYlYvd8/JfuwmR/mVqUOlROOhRtkmtCJ5LSs=; b=zmmLp4DxMPQwknqTKTBWBzRAPuWGMUhfuTOTNuSdx+zCGxSLCUIgZ4Zi3tBUOEjVk4nXGJ RI6uCM0hhxCvZMOjgIXW2UraEqxYsNTtq0YtgG3m7ZsAlf0uZsJEOchmHvIMwbWtyEsI0f SCD+BXa1cAEP6EaZVQ4RLwD6Zu0AEB89B6T5hTm3KUtuyDhGAOxT1igwwIHGjZForEW/QP aRyqRpU1mIbejcYc9kS1PXCLKTYV4g4ily+RqqCyIieBMH3VJkA32EF9zU0y/sOBUEhMnT 6RjJyRj83Fk90sy382zi1XSezmXviA2Xf7O56PN/itDxKUzVx14ufn9A6pOUfA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1594107258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NThXY8gXYlYvd8/JfuwmR/mVqUOlROOhRtkmtCJ5LSs=; b=E3VVJSWVvpLlSz1Sdw0fSbXnvgbEHLre6K7w8IZv3Hm+KuFs4HiOOMQI5TWBU1wLaMXI2Y cZ0ldoZngI21TTCQ== From: "Sebastian A. Siewior" To: Peter Zijlstra Cc: "Ahmed S. Darwish" , Ingo Molnar , Will Deacon , Thomas Gleixner , "Paul E. McKenney" , Steven Rostedt , LKML Subject: Re: [PATCH v3 04/20] lockdep: Add preemption enabled/disabled assertion APIs Message-ID: <20200707073416.yyvxweonkotf72oq@linutronix.de> References: <20200630054452.3675847-1-a.darwish@linutronix.de> <20200630054452.3675847-5-a.darwish@linutronix.de> <20200706205004.GC5523@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200706205004.GC5523@worktop.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-06 22:50:04 [+0200], Peter Zijlstra wrote: > On Tue, Jun 30, 2020 at 07:44:36AM +0200, Ahmed S. Darwish wrote: > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index d74ac0fd6b2d..e5e2e632b749 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -1118,6 +1118,7 @@ config PROVE_LOCKING > > select DEBUG_RWSEMS > > select DEBUG_WW_MUTEX_SLOWPATH > > select DEBUG_LOCK_ALLOC > > + select PREEMPT_COUNT if !ARCH_NO_PREEMPT > > select TRACE_IRQFLAGS > > default n > > help > > I suspect this can be done unconditional, the thing that requires arch > support is CONFIG_PREEMPTION. |$ git grep -C 2 PREEMPT_COUNT lib/Kconfig.debug |lib/Kconfig.debug-config DEBUG_ATOMIC_SLEEP |lib/Kconfig.debug- bool "Sleep inside atomic section checking" |lib/Kconfig.debug: select PREEMPT_COUNT |lib/Kconfig.debug- depends on DEBUG_KERNEL |lib/Kconfig.debug- depends on !ARCH_NO_PREEMPT There will be a build fault if you force preempt_count. Sebastian