Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp917667ybt; Tue, 7 Jul 2020 03:31:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgbbxDpvlKnepBaCezp4enc/OlfVYPfzoaCXUxPHGX9uv7SckHyycDQBZxklFzKQQN9lKU X-Received: by 2002:a17:906:c0da:: with SMTP id bn26mr45687762ejb.359.1594117908437; Tue, 07 Jul 2020 03:31:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594117908; cv=none; d=google.com; s=arc-20160816; b=FqJ7tDm4n7ZbgPgcODJwJY3MHwnWCctVzCwUQf3qAH2bP+nPQqpqcRAjMoy1qZdWZH z+/VFQvq9KDrq+QwMyysqc7ehOwj8y+lfeRw+UGJwTrkBABb7qhFSYFR+nUkJeZdkpz+ oIKaCdDpg7u9J16QwhOL+P/Lpp0ndRR3sMdR9NLqj3+Ie8+H+c7mFjbolGIlFR4ier2r dCp+WWv1mULb4edIqGmcWZxuIjioHT+Z49N9Q9AOqQ/C9nRgWAktaGWXsFXnmV0dhjmi hz5NwTMTNNtEdWuo0RTJdJ9tPPvUPwpLywwOzMeyCjn4yB6mfH3LvaGFdVvr1uMiSVex 6uAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KlAkH8Gx71RMl9Myk/1dznYio72yFBHcD4iCjAu+lSQ=; b=0DuGYzrVwZvPNZbZb8MhC8gdPRT1LgwmVHpRu0rRhZRPlhEdnpmYJO91xN/SFZ4w0c Ugq+hsfhuY7fBLdouyKEuDJiE6fjg96X/8Ne0Dmn7DHL2j3OA5nJD3wBKxLzU835l525 L7Eb07PZtxHAKgLHsbKCniGw/IIEQXjiD8BR4K8+vVrgOVLbHrDanQ5ffhkwYxAM5sPw y2z0kkOu0nacG+PDiW5Vn1ERQnVf4JpPZ0aaTrafDRGLM429rNC5iWTCvPLFKr233Bbf KtaeEcOHV6tD5iHDbKflav86MJWsflyU0C2pAKPAJNoux/6AdfM0D8G2kDX+WNTISmit KN0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="tvG/T9F7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn28si15564463edb.195.2020.07.07.03.31.24; Tue, 07 Jul 2020 03:31:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="tvG/T9F7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727975AbgGGKa6 (ORCPT + 99 others); Tue, 7 Jul 2020 06:30:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:50668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727058AbgGGKa6 (ORCPT ); Tue, 7 Jul 2020 06:30:58 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4EB582065F; Tue, 7 Jul 2020 10:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594117857; bh=eWilmxL1Pp5afMTknP+I9u/CgSUT6XCuGkQ3LcJjx+A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tvG/T9F7afny7pIuP/iUdkoeTgIxUliBMpmWH/65CxrDm0Bp1+wvuPzMdijN5LkeD vCLXbP8KtNdtkYG4dQjLuKYiTn5DXSNsMeDSlksYoO4zRPYv1QOEt3e2JRaWu5OiPJ DTWLAUrFxK8QPQk87x1aLNKvk53EHwvdbXIhfkNs= Date: Tue, 7 Jul 2020 11:30:53 +0100 From: Mark Brown To: Akshu Agrawal Cc: Oder Chiou , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , "moderated list:SOUND" , open list Subject: Re: [PATCH] ASoC: rt5682: Add fmw property to get name of mclk Message-ID: <20200707103053.GF4870@sirena.org.uk> References: <20200707100825.24792-1-akshu.agrawal@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VuQYccsttdhdIfIP" Content-Disposition: inline In-Reply-To: <20200707100825.24792-1-akshu.agrawal@amd.com> X-Cookie: I hate dying. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --VuQYccsttdhdIfIP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 07, 2020 at 03:38:25PM +0530, Akshu Agrawal wrote: > Non-dts based systems can use ACPI DSDT to pass on the mclk. > Thus add fmw property mclk-name to get the name of the system clk > and link it to rt5682 mclk. ACPI doesn't support clocks at all, you need to add a clock binding to ACPI first. The idiomatic way to do this would be to have board specific quirks. > + device_property_read_string(dev, "realtek,mclk-name", &rt5682->pdata.mclk_name); > + No, this is not at all OK - you're adding this via a device property which means that this will show up in the DT bindings too. --VuQYccsttdhdIfIP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8ETtwACgkQJNaLcl1U h9AN6wgAgo5at99d+D1JNkuzvhAbwOx+ZYmgFdlmbYCjbCSCW1rALhghF5kzFGTN Jq+x6GVw0RX2O1hXNrNdhZdNTdRgxiZzOYMGbaLmnj9DSJj57hUEEynQhI0wOpRN /vEG2xzLcd3B4wPhfv7uVzMcO4miHVIkY7RAEYnpeKD4fan0assPAjFJwUX0VCz0 D+qy3FGEpAulCk4HtidGRZVAIF1bsFehFrJc9FWurg2CGQDfyhn4BjVPci3eGl2j Gwgr981VctOUltCO3nmMIeXUiAm4JMdBKb4BBpu13417GjFxXUpY0sPxhnHGmhgH 4t9vGlxY36bl2v6R1B5Y00Pkt30JJA== =n+az -----END PGP SIGNATURE----- --VuQYccsttdhdIfIP--