Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: VTytonoJQ8YRJQemsmG1nj232WAsBk9wtIkiUFGByiEsBK+pfvz+q6Uzt9oJYBDBi7G/NAShoX
 FGnS1Wwi1/9QNiGf2Vras6dNjuOXFZc9zmyKaU5Sb1zvGrKdyb+uSq31G/NSICAKY2LaZnWlv4
 q6kDxz+9AYRlkNgoiJSKAvPzk2J0WaHCkV1RkC694dkws1JAQMUTZZsIPnS0iT81lANOOSI7HK
 Qpp32DvNQQu7+6f8XMr+UTDolR6e7tUErCZpAI8OnPnq04EMpU1MQA7Lp+M4QchqyhL8Hdbaks
 W6I=
Date:   Tue, 7 Jul 2020 12:39:39 +0200
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     David Miller <davem@davemloft.net>
CC:     <nikolay@cumulusnetworks.com>, <roopa@cumulusnetworks.com>,
        <kuba@kernel.org>, <jiri@resnulli.us>, <ivecera@redhat.com>,
        <andrew@lunn.ch>, <UNGLinuxDriver@microchip.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bridge@lists.linux-foundation.org>
Subject: Re: [PATCH net-next 02/12] bridge: uapi: mrp: Extend MRP attributes
 for MRP interconnect
Message-ID: <20200707103939.basybe2a3haweki2@soft-dev3.localdomain>
References: <20200706091842.3324565-1-horatiu.vultur@microchip.com>
 <20200706091842.3324565-3-horatiu.vultur@microchip.com>
 <20200706.122748.828248704525141203.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20200706.122748.828248704525141203.davem@davemloft.net>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

The 07/06/2020 12:27, David Miller wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Horatiu Vultur <horatiu.vultur@microchip.com>
> Date: Mon, 6 Jul 2020 11:18:32 +0200
> 
> > +struct br_mrp_in_state {
> > +     __u16 in_id;
> > +     __u32 in_state;
> > +};
> 
> Put the __u32 first then the __u16.
> 
> > +struct br_mrp_in_role {
> > +     __u16 in_id;
> > +     __u32 ring_id;
> > +     __u32 in_role;
> > +     __u32 i_ifindex;
> > +};
> 
> Likewise.
> 
> > +struct br_mrp_start_in_test {
> > +     __u16 in_id;
> > +     __u32 interval;
> > +     __u32 max_miss;
> > +     __u32 period;
> > +};
> 
> Likewise.
> 
> > +struct br_mrp_in_test_hdr {
> > +     __be16 id;
> > +     __u8 sa[ETH_ALEN];
> > +     __be16 port_role;
> > +     __be16 state;
> > +     __be16 transitions;
> > +     __be32 timestamp;
> > +};
> 
> Likewise.  Put the larger members first.  There is lots of unnecessary
> padding in this structure.

I will do the same here, except for the 'struct br_mrp_in_test_hdr'
because this represents the frame header for InTest frames. And this is
defined in the standard how it has to be. But I will do it for the other
structures.

> 

-- 
/Horatiu